refactor: use english for routes, parameters and internal messages

src/Controller/BoardController.php

@@ -29,11 +29,11 @@ final class BoardController extends AbstractController
     {
     }
 
-    #[Route('/buchen/{type}', name: 'app_board', requirements: ['type' => '[a-z]+'], methods: ['GET'])]
+    #[Route('/book/{type}', name: 'app_board', requirements: ['type' => '[a-z]+'], methods: ['GET'])]
     public function index(Request $request, string $type): Response
     {
         $resourceType = $this->resourceType($type);
-        $date = DateParam::parseOrToday($request->query->getString('tag'));
+        $date = DateParam::parseOrToday($request->query->getString('date'));
 
         return $this->render('board/index.html.twig', $this->board->context(
             $resourceType,
@@ -51,7 +51,7 @@ final class BoardController extends AbstractController
      * client-side event choreography. Requests without the htmx header get a plain redirect
      * rather than a bare pair of fragments, so the URL stays shareable.
      */
-    #[Route('/buchen/{type}/tag/{date}', name: 'app_board_day', requirements: ['type' => '[a-z]+', 'date' => DateParam::PATTERN], methods: ['GET'])]
+    #[Route('/book/{type}/day/{date}', name: 'app_board_day', requirements: ['type' => '[a-z]+', 'date' => DateParam::PATTERN], methods: ['GET'])]
     public function day(Request $request, string $type, string $date): Response
     {
         $resourceType = $this->resourceType($type);
@@ -76,19 +76,17 @@ final class BoardController extends AbstractController
      */
     public static function timeOf(Request $request): TimeRange
     {
-        return TimeRange::parse($request->query->getString('von'), $request->query->getString('bis'))
+        return TimeRange::parse($request->query->getString('from'), $request->query->getString('to'))
             ?? TimeRange::wholeDay();
     }
 
     /**
-     * Route requirements cannot call a method, so the slug is matched loosely and resolved here.
+     * Route requirements cannot enumerate the enum, so {type} is matched loosely and resolved
+     * here -- an unknown kind is a 404 rather than a 500.
      */
-    private function resourceType(string $slug): ResourceType
+    private function resourceType(string $value): ResourceType
     {
-        try {
-            return ResourceType::fromSlug($slug);
-        } catch (\ValueError $e) {
-            throw $this->createNotFoundException($e->getMessage(), $e);
-        }
+        return ResourceType::tryFrom($value)
+            ?? throw $this->createNotFoundException(\sprintf('Unknown bookable kind "%s".', $value));
     }
 }