fix: offer the questionnaire after every placement, the bus part to escorts

config/questionnaires/teamer_assignment.yaml

@@ -1,21 +1,24 @@
-# Questionnaire a teamer fills in after an assignment with bus escort.
+# Questionnaire a teamer fills in after a placement (Disposition, not SeasonAssignment).
 #
 # Replaces the Google forms "RL-Feedback 25-26" and "Bus-Feedback 25-26"; the question-by-question
-# spec, with every decision taken, is in .ddev/plans/questionnaires/. Questions whose answer the
-# disposition already knows (name, job profile, house, dates, destination, escort pickup) are not
-# asked: they are snapshotted into the response's context instead.
+# spec, with every decision taken, is in .ddev/plans/questionnaires/. Every teamer gets the
+# sections up to "Sonstiges"; the sections marked `only_for: bus_escort` are added when the
+# assignment had a bus escort. Questions whose answer the disposition already knows (name, job
+# profile, house, dates, destination, escort pickup) are not asked: they are snapshotted into the
+# response's context instead.
 #
 # Parsed and validated by App\Config\QuestionnaireCatalog; QuestionnaireCatalogTest builds it.
 #
 # Labels, help texts, section titles and option labels may be edited in place. Renaming or
 # removing a question or option key, or changing a type, needs a new version: copy this file to
-# teamer_escort.v1.yaml first, then bump `version` here. Submitted answers are keyed by it.
+# teamer_assignment.v1.yaml first, then bump `version` here. Submitted answers are keyed by it.
 #
+# Section fields: key, title, only_for (a App\Enum\QuestionnaireFlag value), questions.
 # Question fields: key, label, type (text | textarea | choice | multi | date | rating),
 # required (default false), help, widget (choice only: radio | dropdown, default radio),
 # options (choice and multi only), show_if ({question, equals | in | lte}, earlier questions only).
 
-key: teamer_escort
+key: teamer_assignment
 version: 1
 title: "Reiseleiter/-in Feedback"
 description: |-
@@ -135,6 +138,7 @@ sections:
 
   - key: bus_trip
     title: "Busfahrt"
+    only_for: bus_escort
     questions:
       - key: direction
         label: "Hin- oder Rückfahrt"
@@ -163,6 +167,7 @@ sections:
 
   - key: bus_team
     title: "Busteam"
+    only_for: bus_escort
     questions:
       - key: driver_names
         label: "Busfahrer-Namen:"
@@ -171,6 +176,7 @@ sections:
 
   - key: bus_first_pickup
     title: "1. Abfahrtsort"
+    only_for: bus_escort
     questions:
       - key: on_time_at_first_pickup
         label: "Bus pünktlich am 1. Abfahrtsort?"
@@ -188,6 +194,7 @@ sections:
 
   - key: bus_rating
     title: "Bewertung Bus & Fahrer"
+    only_for: bus_escort
     questions:
       - key: overall_impression
         label: "Gesamteindruck des Busses"
@@ -268,6 +275,7 @@ sections:
 
   - key: bus_pickups
     title: "Ladestellen"
+    only_for: bus_escort
     questions:
       - key: drivers_knew_pickups
         label: "Waren den Fahrern alle Abfahrtsorte bekannt?"
@@ -285,6 +293,7 @@ sections:
 
   - key: bus_destination
     title: "Zielkenntnis"
+    only_for: bus_escort
     questions:
       - key: drivers_knew_destination
         label: "War den Busfahrern der Zielort und die Ausladestelle bekannt?"
@@ -296,6 +305,7 @@ sections:
 
   - key: bus_equipment
     title: "Bus, Technik & Allgemeines"
+    only_for: bus_escort
     questions:
       - key: video
         label: "Video/DVD-Gerät"
@@ -345,6 +355,7 @@ sections:
 
   - key: bus_damage
     title: "Schäden"
+    only_for: bus_escort
     questions:
       - key: bus_damage
         label: "Entstanden während der Fahrt Schäden am Bus?"
@@ -363,6 +374,7 @@ sections:
 
   - key: bus_remarks
     title: "Anmerkungen zur Busfahrt"
+    only_for: bus_escort
     questions:
       - key: bus_remarks
         label: "Das ging gar nicht / ist besonders hervorzuheben:"

config/services.yaml

@@ -90,9 +90,9 @@ parameters:
     season_start: '11-01'
     season_end: '04-01'
 
-    # The teamer questionnaire after a bus escort (config/questionnaires/teamer_escort.yaml) is
-    # offered for assignments ending on or after this day (Y-m-d). Set it to the deployment day:
-    # without a cutoff every past escort would show up as pending on the teamers' dashboards.
+    # The teamer questionnaire after a placement (config/questionnaires/teamer_assignment.yaml) is
+    # offered for placements ending on or after this day (Y-m-d). Set it to the deployment day:
+    # without a cutoff every past placement would show up as pending on the teamers' dashboards.
     # null offers it to nobody.
     questionnaire_go_live: ~