fix: correctly calculate due dates for contract and invoice uploads

2026-08-17 12:49:36 +02:00
parent 0e1df6da7c
commit 31149fdd13
4 changed files with 145 additions and 7 deletions
@@ -47,6 +47,19 @@ class DispositionTest extends TestCase
        $this->assertFalse($disposition->isContractDue(self::CONTRACT_DEADLINE_DAYS));
    }

+    /**
+     * A short-notice assignment can end before the normal $deadlineDays window would even
+     * start (assignment ends in 4 days, but the normal deadline is 5 days out). Left uncapped,
+     * dueDateFrom > dueDateTo made isStarted() and isEnded() equal at every instant, so this
+     * never returned true.
+     */
+    public function testTheContractIsDueImmediatelyWhenTheAssignmentEndsBeforeTheNormalDeadline(): void
+    {
+        $disposition = $this->createDisposition(createdAt: 'today', assignmentEndsIn: '+4 days');
+
+        $this->assertTrue($disposition->isContractDue(self::CONTRACT_DEADLINE_DAYS));
+    }
+
    public function testAnUploadedContractIsNeverDue(): void
    {
        $disposition = $this->createDisposition(createdAt: 'today -60 days', assignmentEndsIn: '+30 days');