feat: financial data check for teamers, improved enforced checks logic

addresses #869at5rtp

config/services.yaml

@@ -9,6 +9,11 @@ parameters:
 
     teamer_inactive_period: '-2 years'
 
+    # Dates (MM-DD) on which teamers must re-confirm their personal data.
+    personal_data_check_deadlines:
+        - '04-01'
+        - '10-01'
+
     # Houses, hotel code: name. The name is used both as a label and to match
     # destination.hotel, the code to match destination.hotelCode.
     houses:
@@ -175,13 +180,20 @@ services:
 
     App\RequiredTeamerCheck\RequiredTeamerCheckRegistry:
         arguments:
+            # Presentation order only. Each check must point at a page that clears
+            # that check alone, so a teamer can always work through them whatever
+            # the order — never make correctness depend on this list.
             $checks:
                 - '@App\RequiredTeamerCheck\DriverLicenseRequiredCheck'
+                - '@App\RequiredTeamerCheck\FinancialDataRequiredCheck'
                 - '@App\RequiredTeamerCheck\PersonalDataVerificationRequiredCheck'
 
     App\RequiredTeamerCheck\PersonalDataVerificationRequiredCheck:
         arguments:
-            $dataVerificationDeadlines: '%env(csv:PERSONAL_DATA_CHECK_DEADLINES)%'
+            $deadlines: !service
+                class: App\RequiredTeamerCheck\RecurringDeadlines
+                arguments:
+                    $deadlines: '%personal_data_check_deadlines%'
 
     app.upload_namer:
         class: App\Service\Upload\UploadNamer