fix: correctly apply due dates for contract and invoice upload reminders

config/email_texts.yaml

@@ -96,6 +96,19 @@ texts:
         body: |-
             vielen Dank für deinen Einsatz {destination}. Bitte lade deine Honorarnote innerhalb der nächsten {invoiceUploadDeadlineDays} Tage hoch, damit wir dein Honorar bearbeiten können. Solltest du deine Honorarnote zu spät hochladen, können wir sie eventuell nicht mehr annehmen.
 
+    # Goes out on the last day of the upload period, so it must not promise any time left.
+    reminder_invoice_upload_final:
+        label: 'Letzte Erinnerung: Honorarnote hochladen'
+        placeholders: ['destination', 'invoiceUploadDeadlineDays']
+        subject: 'Letzte Erinnerung: Deine Honorarnote fehlt'
+        headline: 'Hallo aus Köln,'
+        body: |-
+            für deinen Einsatz {destination} liegt uns noch immer keine Honorarnote vor.
+
+            Heute endet die Frist von {invoiceUploadDeadlineDays} Tagen nach deinem Einsatz. *Bitte lade deine Honorarnote noch heute hoch* - danach können wir sie eventuell nicht mehr annehmen.
+
+            Bei Fragen melde dich gerne unter [email protected]
+
     reminder_disposition:
         label: 'Erinnerung: Einsatz steht bevor'
         placeholders: ['destination', 'jobProfile', 'product', 'dateFrom', 'dateTo', 'diffInDays', 'invoiceUploadDeadlineDays']

config/services.yaml

@@ -9,11 +9,14 @@ parameters:
 
     teamer_inactive_period: '-2 years'
 
-    # Deadlines quoted to teamers in the transactional mails. They are passed to the mail
-    # texts as placeholders rather than typed into the wording, so what an admin edits can
-    # never drift from the period the application actually works with.
-    contract_upload_deadline_days: 7
-    # Also drives when the reminder goes out: three days before the deadline expires.
+    # The contract upload period, counted from the creation of the disposition. This is the
+    # single definition: the reminder mail, the "Honorarvertrag fällig" flag on the teamer
+    # dashboard, the admin list of overdue contracts and the wording of the mails all read it,
+    # so they cannot mark the same disposition due on three different days.
+    contract_upload_deadline_days: 5
+
+    # The invoice upload period, counted from the end of the assignment. The teamer is
+    # reminded the day after the assignment ends and again on the last day of this period.
     invoice_upload_deadline_days: 14
 
     # Messenger transport the mails of a teamer mailing are queued on. An X-Bus-Transport