chore: drop the teamer provisioning feature flag
This commit is contained in:
1 parent
b530679658
commit
5141673bcd
5 files changed
+135
-82
No files matched your search
@@ -7,7 +7,6 @@ use App\Htmx\HxRedirectResponse;
|
||||
use App\Model\TeamerProvisioningResult;
|
||||
use App\Service\Teamer\TeamerProvisioner;
|
||||
use App\Service\Teamer\TeamerProvisioningException;
|
||||
use Flagception\Manager\FeatureManagerInterface;
|
||||
use Psr\Log\LoggerInterface;
|
||||
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
|
||||
use Symfony\Component\HttpFoundation\Request;
|
||||
@@ -19,14 +18,14 @@ use Symfony\Component\Security\Http\Attribute\IsGranted;
|
||||
* Makes a teamer out of an applicant who passed the interview: one click, because the submission
|
||||
* carries everything the CRM needs and there is nothing left for the reviewer to type.
|
||||
*
|
||||
* Behind a feature flag, because provisioning writes to the production CRM and cannot be rehearsed
|
||||
* anywhere else - the teamer selection is only changeable there.
|
||||
* The click writes to the CRM for real - three writes, none of them undoable from here - so what
|
||||
* goes to BusPro is shown in the confirmation before it goes, and TeamerProvisioner refuses a
|
||||
* submission it cannot provision before sending anything.
|
||||
*/
|
||||
class CreateTeamerController extends AbstractController
|
||||
{
|
||||
public function __construct(
|
||||
private readonly TeamerProvisioner $provisioner,
|
||||
private readonly FeatureManagerInterface $featureManager,
|
||||
private readonly LoggerInterface $logger,
|
||||
) {
|
||||
}
|
||||
@@ -35,10 +34,6 @@ class CreateTeamerController extends AbstractController
|
||||
#[IsGranted('ROLE_TEAM_ADMIN')]
|
||||
public function index(ApplicationFormSubmission $submission, Request $request): Response
|
||||
{
|
||||
if (false === $this->featureManager->isActive('application_form_teamer_provisioning')) {
|
||||
throw $this->createNotFoundException('Teamer provisioning is not enabled');
|
||||
}
|
||||
|
||||
if (false === $request->isMethod(Request::METHOD_POST)) {
|
||||
return $this->render('admin/application_form_submission/modal_create_teamer.html.twig', [
|
||||
'submission' => $submission,
|
||||
|
||||
Reference in new issue
Block a user