EP/myep-team
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: correct access check to provide feedback

Browse Source
This commit is contained in:
Björn Fromme
2025-01-13 11:05:10 +01:00
parent ec3d821637
commit 520e6b79f0
1 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Security/Voter/DispositionVoter.php
+5 -13
View File
@@ -43,24 +43,16 @@ class DispositionVoter extends Voter
$disposition = $subject; $disposition = $subject;
return match ($attribute) { return match ($attribute) {
static::VIEW, static::EDIT, static::CONTRACT, static::INVOICE => $this->assertAdministrativeAccess() static::VIEW, static::EDIT, static::CONTRACT, static::INVOICE =>
$this->security->isGranted('ROLE_ADMINISTRATIVE')
|| $this->assertTeamerAccess($token, $disposition), || $this->assertTeamerAccess($token, $disposition),
static::DELETE => $this->assertAdminAccess(), static::DELETE => $this->security->isGranted('ROLE_ADMIN'),
static::FEEDBACK => $this->assertAdminAccess() || $this->assertHouseManagerAccess($token, $disposition), static::FEEDBACK => $this->security->isGranted('ROLE_ADMINISTRATIVE')
|| $this->assertHouseManagerAccess($token, $disposition),
default => false, default => false,
}; };
} }
private function assertAdminAccess(): bool
{
return $this->security->isGranted('ROLE_ADMIN');
}
private function assertAdministrativeAccess(): bool
{
return $this->security->isGranted('ROLE_ADMINISTRATIVE');
}
private function assertHouseManagerAccess(TokenInterface $token, Disposition $disposition): bool private function assertHouseManagerAccess(TokenInterface $token, Disposition $disposition): bool
{ {
if (false === $this->security->isGranted('ROLE_HOUSE_MANAGER')) { if (false === $this->security->isGranted('ROLE_HOUSE_MANAGER')) {