From 6e6bdd1c08817d420f1f089f0440dc40e87f57a8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Fromme?= <fromme@dreipunktnull.com>
Date: Mon, 25 Aug 2025 11:30:32 +0200
Subject: [PATCH] fix: improved database query for teamer assignment list

---
 src/Repository/AssignmentRepository.php | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/Repository/AssignmentRepository.php b/src/Repository/AssignmentRepository.php
index 3520480..9034bb7 100644
--- a/src/Repository/AssignmentRepository.php
+++ b/src/Repository/AssignmentRepository.php
@@ -87,11 +87,16 @@ class AssignmentRepository extends ServiceEntityRepository
             ->setParameter('now', new \DateTimeImmutable())
         ;
 
-        if (0 === $teamer->getTrainingAttendances()->count() && 0 === $teamer->getLicenses()->count()) {
+        // exclude job profiles that require trainings for teamers that didn't attend any
+        if (0 === $teamer->getTrainingAttendances()->count()) {
+            $qb->andWhere($qb->expr()->isNull('required_training'));
+        }
+
+        // exclude job profiles that require licenses for teamers that don't have any
+        if (0 === $teamer->getLicenses()->count()) {
             $qb
                 ->andWhere($qb->expr()->eq('job_profile.requiredLicenses', ':requiredLicenses'))
                 ->setParameter('requiredLicenses', '[]')
-                ->andWhere($qb->expr()->isNull('required_training'))
             ;
         }