docs: drop code references to local plan files
This commit is contained in:
1 parent
2a554bb7bf
commit
96d49fc488
15 files changed
+33
-40
No files matched your search
@@ -194,8 +194,7 @@ class ResponseParserTest extends TestCase
|
||||
/**
|
||||
* The write answers idadresse + idperson + änderung, not a selection tree - the shape
|
||||
* createProfileUpdateResponse() reads. It used to be routed to the CRM attribute parser, which
|
||||
* would have returned an empty response with every role flag false
|
||||
* (.ddev/plans/buspro-crm-selection-write.md).
|
||||
* would have returned an empty response with every role flag false.
|
||||
*/
|
||||
public function testParseCrmSelectionWriteResponse(): void
|
||||
{
|
||||
|
||||
@@ -14,8 +14,8 @@ use Symfony\Component\HttpFoundation\Response;
|
||||
/**
|
||||
* Everything around the provisioning click that can be exercised without writing to BusPro.
|
||||
*
|
||||
* The write itself cannot: the teamer CRM selection is only changeable in the production database
|
||||
* (.ddev/plans/buspro-crm-selection-write.md), and a POST that gets as far as the api client would
|
||||
* The write itself cannot: the teamer CRM selection is only changeable in the production database,
|
||||
* and a POST that gets as far as the api client would
|
||||
* open a socket to it from a test. TeamerProvisionerTest covers the flow against a mocked client;
|
||||
* what is left here is the route, the confirmation and the one POST that is safe to make - a
|
||||
* submission TeamerProvisioner refuses before it sends anything.
|
||||
|
||||
@@ -13,8 +13,8 @@ use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
|
||||
use Symfony\Component\HttpFoundation\Response;
|
||||
|
||||
/**
|
||||
* The cases here are the ones the TYPO3 side actually produces
|
||||
* (.ddev/plans/MYEP-APPLICATION-ENDPOINT.md §8): labels with slashes and umlauts, a long textarea
|
||||
* The cases here are the ones the TYPO3 side actually produces:
|
||||
* labels with slashes and umlauts, a long textarea
|
||||
* answer, a duplicate label, and a mapped key this application does not know - which must not be a
|
||||
* 400, or a later mapping change on the website silently stops every submission of that form.
|
||||
*
|
||||
@@ -22,8 +22,7 @@ use Symfony\Component\HttpFoundation\Response;
|
||||
* birthDate, email, gender, eu, street, zipCode and city, and every one of them is a 400 when it is
|
||||
* missing. That is
|
||||
* deliberately harsh - a 400 costs a whole application - and each rejection case is pinned here
|
||||
* one field at a time, because these are the fields a teamer cannot be provisioned without
|
||||
* (.ddev/plans/application-form-teamer-provisioning.md).
|
||||
* one field at a time, because these are the fields a teamer cannot be provisioned without.
|
||||
*/
|
||||
class ApplicationFormControllerTest extends WebTestCase
|
||||
{
|
||||
@@ -412,7 +411,7 @@ class ApplicationFormControllerTest extends WebTestCase
|
||||
|
||||
/**
|
||||
* A duplicate label is disambiguated by the identifier on the TYPO3 side, so both answers
|
||||
* survive as separate keys (§3.3). The order is MySQL's, not the form's - a json column
|
||||
* survive as separate keys. The order is MySQL's, not the form's - a json column
|
||||
* sorts an object's keys by length - so only the set of labels is pinned here.
|
||||
*/
|
||||
public function testEveryLabelSurvivesIncludingADisambiguatedDuplicate(): void
|
||||
@@ -528,7 +527,7 @@ class ApplicationFormControllerTest extends WebTestCase
|
||||
}
|
||||
|
||||
/**
|
||||
* §5.1 is not implemented yet: a double-clicked submit button stores two rows for now, and
|
||||
* Dedupe is not implemented yet: a double-clicked submit button stores two rows for now, and
|
||||
* this pins that it is a known state rather than an accident.
|
||||
*/
|
||||
public function testTheSamePayloadTwiceIsStoredTwiceForNow(): void
|
||||
|
||||
@@ -13,7 +13,7 @@ use App\Service\Assignment\AssignmentPlanner;
|
||||
use PHPUnit\Framework\TestCase;
|
||||
|
||||
/**
|
||||
* One test per row of the planner table in .ddev/plans/teamer-auto-assignments-plan.md.
|
||||
* Pins the rules listed on AssignmentPlanner, one test per case.
|
||||
*/
|
||||
class AssignmentPlannerTest extends TestCase
|
||||
{
|
||||
|
||||
@@ -24,10 +24,9 @@ use Psr\Log\NullLogger;
|
||||
|
||||
/**
|
||||
* The three provisioning writes are not a transaction and only the first and the third can be
|
||||
* rehearsed against BusPro's test database - the teamer selection is changeable in production only
|
||||
* (.ddev/plans/buspro-crm-selection-write.md). So the orchestration is pinned here against a mocked
|
||||
* client: what runs, in which order, what is persisted before the next step, and what a retry does
|
||||
* after a failure halfway.
|
||||
* rehearsed against BusPro's test database - the teamer selection is changeable in production only.
|
||||
* So the orchestration is pinned here against a mocked client: what runs, in which order, what is
|
||||
* persisted before the next step, and what a retry does after a failure halfway.
|
||||
*/
|
||||
#[AllowMockObjectsWithoutExpectations]
|
||||
class TeamerProvisionerTest extends TestCase
|
||||
|
||||
Reference in new issue
Block a user