EP/myep-team
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use correct return value of repository

Browse Source
This commit is contained in:
Björn Fromme
2023-12-08 10:20:59 +01:00
parent be42f06ae2
commit 9d76865ca4
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Service/Cron/FeedbackReminderService.php
+6 -6
View File
@@ -4,7 +4,7 @@ namespace App\Service\Cron;
use App\BusProNet\DataProvider\HotelDataProvider; use App\BusProNet\DataProvider\HotelDataProvider;
use App\Email\Mailer; use App\Email\Mailer;
use App\Entity\Feedback; use App\Entity\Disposition;
use App\Entity\User; use App\Entity\User;
use App\Repository\DispositionRepository; use App\Repository\DispositionRepository;
use App\Repository\UserRepository; use App\Repository\UserRepository;
@@ -23,14 +23,14 @@ class FeedbackReminderService
public function sendFeedbackReminders(): string public function sendFeedbackReminders(): string
{ {
/** @var Feedback[] $pendingFeedbacks */ /** @var Disposition[] $dispositionsWithPendingFeedbacks */
$pendingFeedbacks = $this->dispositionRepository->getPendingFeedbacks(); $dispositionsWithPendingFeedbacks = $this->dispositionRepository->findDispositionsWithPendingFeedback();
$sortedFeedbacks = []; $sortedFeedbacks = [];
foreach ($pendingFeedbacks as $feedback) { foreach ($dispositionsWithPendingFeedbacks as $disposition) {
// Get hotel by bus pro id // Get hotel by bus pro id
$hotelBusProId = $feedback->getDestination()->getHotelBusProId(); $hotelBusProId = $disposition->getAssignment()->getDestination()->getHotelBusProId();
$hotel = $this->hotelDataProvider->get($hotelBusProId); $hotel = $this->hotelDataProvider->get($hotelBusProId);
if (null === $hotel) { if (null === $hotel) {
@@ -46,7 +46,7 @@ class FeedbackReminderService
} }
// Sort feedback by hotel base code // Sort feedback by hotel base code
$sortedFeedbacks[$hotelBaseCode][] = $feedback; $sortedFeedbacks[$hotelBaseCode][] = $disposition;
} }
// Determine hotel managers to notify // Determine hotel managers to notify