refactor: split the questionnaire into teamer and bus feedback

src/Controller/Administrative/Questionnaire/IndexController.php

@@ -13,8 +13,9 @@ use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Http\Attribute\IsGranted;
 
 /**
- * The submitted teamer questionnaires. Only administrative users read them: they rate the house
- * manager among others, so house managers are deliberately not let in.
+ * The submitted responses to one questionnaire, teamer or bus feedback. Only administrative users
+ * read them: they rate the house manager among others, so house managers are deliberately not
+ * let in.
  */
 class IndexController extends AbstractController
 {
@@ -26,14 +27,25 @@ class IndexController extends AbstractController
     ) {
     }
 
-    #[Route('/administrative/questionnaire', name: 'app_administrative_questionnaire_index')]
+    #[Route(
+        '/administrative/questionnaire/list/{questionnaire}',
+        name: 'app_administrative_questionnaire_index',
+        requirements: ['questionnaire' => '[a-z0-9_]+'],
+        defaults: ['questionnaire' => QuestionnaireCatalog::TEAMER_FEEDBACK],
+    )]
     #[IsGranted('ROLE_ADMINISTRATIVE')]
-    public function index(Request $request): Response
+    public function index(string $questionnaire, Request $request): Response
     {
+        $keys = $this->catalog->keys();
+
+        if (!in_array($questionnaire, $keys, true)) {
+            throw $this->createNotFoundException(sprintf('No questionnaire "%s"', $questionnaire));
+        }
+
         $filterDto = $this->filterHandler->getFilterSettings();
 
         $pagination = $this->paginator->paginate(
-            $this->responseRepository->getListQuery(QuestionnaireCatalog::TEAMER_ASSIGNMENT, $filterDto),
+            $this->responseRepository->getListQuery($questionnaire, $filterDto),
             $request->query->getInt('page', 1),
             $request->query->getInt('limit', 50),
             [
@@ -43,7 +55,9 @@ class IndexController extends AbstractController
         );
 
         return $this->render('administrative/questionnaire/index.html.twig', [
-            'definition' => $this->catalog->get(QuestionnaireCatalog::TEAMER_ASSIGNMENT),
+            'definition' => $this->catalog->get($questionnaire),
+            // for switching between the questionnaires
+            'definitions' => array_map($this->catalog->get(...), $keys),
             'pagination' => $pagination,
             'filterDto' => $filterDto,
         ]);