refactor: split the questionnaire into teamer and bus feedback

tests/Service/Questionnaire/DispositionContextTest.php

@@ -4,13 +4,13 @@ declare(strict_types=1);
 
 namespace App\Tests\Service\Questionnaire;
 
+use App\Config\QuestionnaireCatalog;
 use App\Entity\Application;
 use App\Entity\Assignment;
 use App\Entity\Destination;
 use App\Entity\Disposition;
 use App\Entity\JobProfile;
 use App\Entity\Teamer;
-use App\Enum\QuestionnaireFlag;
 use App\Service\Questionnaire\DispositionContext;
 use PHPUnit\Framework\TestCase;
 
@@ -43,10 +43,16 @@ class DispositionContextTest extends TestCase
         $this->assertNull($context['escortPickupDate']);
     }
 
-    public function testOnlyABusEscortGetsTheBusSections(): void
+    public function testEveryoneGetsTheTeamerFeedbackAndABusEscortTheBusFeedbackToo(): void
     {
-        $this->assertSame([QuestionnaireFlag::BUS_ESCORT], DispositionContext::flags($this->disposition(pickup: 4711)->getAssignment()));
-        $this->assertSame([], DispositionContext::flags($this->disposition(pickup: 0)->getAssignment()));
+        $this->assertSame(
+            [QuestionnaireCatalog::TEAMER_FEEDBACK, QuestionnaireCatalog::BUS_FEEDBACK],
+            DispositionContext::questionnaires($this->disposition(pickup: 4711)->getAssignment()),
+        );
+        $this->assertSame(
+            [QuestionnaireCatalog::TEAMER_FEEDBACK],
+            DispositionContext::questionnaires($this->disposition(pickup: 0)->getAssignment()),
+        );
     }
 
     private function disposition(int $pickup): Disposition