feat: pending roles from crm to be confirmed by superadmins

2026-08-10 12:26:21 +02:00
parent 681734533f
commit b01c2e84c7
26 changed files with 907 additions and 150 deletions
@@ -0,0 +1,98 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Tests\Form;
+
+use App\Entity\User;
+use App\Form\UserType;
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Symfony\Component\Form\FormFactoryInterface;
+
+class UserTypeTest extends KernelTestCase
+{
+    public function testRendersRolesWithoutSynthesizedRoles(): void
+    {
+        $user = (new User())
+            ->setRoles(['ROLE_ADMIN'])
+            ->setSuperAdmin(true)
+        ;
+
+        $view = $this->createForm($user)->createView();
+
+        // ROLE_USER and ROLE_SUPER_ADMIN are synthesized by getRoles() and must not leak in
+        $this->assertSame(['ROLE_ADMIN'], $view->children['roles']->vars['data']);
+    }
+
+    public function testApprovingAPendingRoleClearsTheMarker(): void
+    {
+        $user = (new User())->setRoles([User::PENDING_ROLES['ROLE_ADMIN']]);
+
+        $form = $this->createForm($user);
+
+        // the marker is not an assignable choice and must not reach the field
+        $this->assertSame([], $form->createView()->children['roles']->vars['data']);
+
+        $form->submit([
+            'roles' => ['ROLE_ADMIN'],
+            'superAdmin' => null,
+            'hotelCodes' => [],
+        ]);
+
+        $this->assertTrue($form->isValid());
+        $this->assertSame(['ROLE_ADMIN'], $user->getAssignedRoles());
+        $this->assertSame([], $user->getPendingRoles());
+    }
+
+    public function testRendersHotelCodesNotCoveredByTheConfiguredMap(): void
+    {
+        $user = (new User())->setHotelCodes(['XYZ']);
+
+        $view = $this->createForm($user)->createView();
+
+        $this->assertSame(['XYZ'], $view->children['hotelCodes']->vars['data']);
+    }
+
+    public function testSubmitStoresAssignedRolesOnly(): void
+    {
+        $user = (new User())->setRoles(['ROLE_TEAMER']);
+
+        $form = $this->createForm($user);
+        $form->submit([
+            'roles' => ['ROLE_ADMIN'],
+            'superAdmin' => '1',
+            'hotelCodes' => [],
+        ]);
+
+        $this->assertTrue($form->isValid());
+        $this->assertSame(['ROLE_ADMIN'], $user->getAssignedRoles());
+        $this->assertTrue($user->isSuperAdmin());
+    }
+
+    public function testSubmitRejectsSuperAdminWithoutRoleAdmin(): void
+    {
+        $user = new User();
+
+        $form = $this->createForm($user);
+        $form->submit([
+            'roles' => ['ROLE_MANAGER'],
+            'superAdmin' => '1',
+            'hotelCodes' => [],
+        ]);
+
+        $this->assertFalse($form->isValid());
+        $this->assertCount(1, $form->get('superAdmin')->getErrors());
+    }
+
+    private function createForm(User $user): \Symfony\Component\Form\FormInterface
+    {
+        self::bootKernel();
+
+        /** @var FormFactoryInterface $formFactory */
+        $formFactory = self::getContainer()->get(FormFactoryInterface::class);
+
+        return $formFactory->create(UserType::class, $user, [
+            'csrf_protection' => false,
+        ]);
+    }
+}