From be42f06ae2c66fbd75bbb95b41e3680bb2b3982c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Fromme?= <fromme@dreipunktnull.com>
Date: Fri, 8 Dec 2023 10:20:34 +0100
Subject: [PATCH] chore: streamline log/cli messages

---
 src/Service/Cron/FeedbackReminderService.php | 4 ++++
 src/Service/Cron/UploadReminderService.php   | 8 ++++----
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/Service/Cron/FeedbackReminderService.php b/src/Service/Cron/FeedbackReminderService.php
index 13d0c0f..fe846a9 100644
--- a/src/Service/Cron/FeedbackReminderService.php
+++ b/src/Service/Cron/FeedbackReminderService.php
@@ -57,6 +57,10 @@ class FeedbackReminderService
             'hotelCode' => $hotelBaseCodes,
         ]);
 
+        if (0 === count($hotelManagers)) {
+            return 'No feedback reminders to be sent to hotel managers';
+        }
+
         foreach ($hotelManagers as $manager) {
             $this->mailer->createAndSendEmail([
                 'feedbacks' => $sortedFeedbacks[$manager->getHotelCode()],
diff --git a/src/Service/Cron/UploadReminderService.php b/src/Service/Cron/UploadReminderService.php
index 43d297d..800eb7e 100644
--- a/src/Service/Cron/UploadReminderService.php
+++ b/src/Service/Cron/UploadReminderService.php
@@ -53,7 +53,7 @@ class UploadReminderService
         ;
 
         if (0 === $count = count($dispositions)) {
-            $message = 'No reminders regarding due contract uploads to be sent';
+            $message = 'No due contract upload reminders to be sent to teamers';
             $this->logger->info($message);
 
             return $message;
@@ -71,7 +71,7 @@ class UploadReminderService
             ]);
         }
 
-        $message = 'Sent '.$count.' reminders about due contract uploads';
+        $message = 'Sent '.$count.' due contract upload reminders to teamers';
         $this->logger->info($message);
 
         return $message;
@@ -111,7 +111,7 @@ class UploadReminderService
         ;
 
         if (0 === $count = count($dispositions)) {
-            $message = 'No reminders regarding due invoice uploads to be sent';
+            $message = 'No due invoice upload reminders to be sent to teamers';
             $this->logger->info($message);
 
             return $message;
@@ -129,7 +129,7 @@ class UploadReminderService
             ]);
         }
 
-        $message = 'Sent '.$count.' reminders about due invoice uploads';
+        $message = 'Sent '.$count.' due invoice upload reminders to teamers';
         $this->logger->info($message);
 
         return $message;