EP/myep-team
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: rename ROLE_ADMIN to ROLE_TEAM_ADMIN since being too broad

Browse Source
This commit is contained in:
fromme
2026-09-16 17:20:45 +02:00
parent 39a343911a
commit d4908b6ab9
75 changed files with 212 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Form/UserTypeTest.php
+10 -10
View File
@@ -19,7 +19,7 @@ class UserTypeTest extends KernelTestCase
public function testRolesAndHotelCodesAreNotFields(): void
{
$user = (new User())
->setRoles(['ROLE_ADMIN'])
->setRoles(['ROLE_TEAM_ADMIN'])
->setHotelCodes(['DKS'])
;
@@ -39,7 +39,7 @@ class UserTypeTest extends KernelTestCase
$form = $this->createForm($user);
$form->submit([
'roles' => ['ROLE_ADMIN'],
'roles' => ['ROLE_TEAM_ADMIN'],
'hotelCodes' => ['DKS'],
'disabled' => null,
]);
@@ -49,14 +49,14 @@ class UserTypeTest extends KernelTestCase
}
/**
* Super admin is an elevation of ROLE_ADMIN, so it is not on offer for anybody else -
* Super admin is an elevation of ROLE_TEAM_ADMIN, so it is not on offer for anybody else -
* offering it would only ever produce the violation from User::validateSuperAdmin().
*/
public function testSuperAdminIsOnlyOfferedToAnAdmin(): void
{
$this->assertTrue($this->createForm((new User())->setRoles(['ROLE_ADMIN']))->has('superAdmin'));
$this->assertTrue($this->createForm((new User())->setRoles(['ROLE_TEAM_ADMIN']))->has('superAdmin'));
$this->assertFalse($this->createForm((new User())->setRoles(['ROLE_MANAGER']))->has('superAdmin'));
$this->assertFalse($this->createForm((new User())->setRoles([User::PENDING_ROLES['ROLE_ADMIN']]))->has('superAdmin'));
$this->assertFalse($this->createForm((new User())->setRoles([User::PENDING_ROLES['ROLE_TEAM_ADMIN']]))->has('superAdmin'));
}
/**
@@ -84,7 +84,7 @@ class UserTypeTest extends KernelTestCase
public function testSuperAdminIsAppointed(): void
{
$user = (new User())->setRoles(['ROLE_ADMIN']);
$user = (new User())->setRoles(['ROLE_TEAM_ADMIN']);
$form = $this->createForm($user);
$form->submit([
@@ -98,7 +98,7 @@ class UserTypeTest extends KernelTestCase
public function testSubmitBlocksTheAccountWithAReason(): void
{
$user = (new User())->setRoles(['ROLE_ADMIN']);
$user = (new User())->setRoles(['ROLE_TEAM_ADMIN']);
$form = $this->createForm($user);
$form->submit([
@@ -117,7 +117,7 @@ class UserTypeTest extends KernelTestCase
public function testSubmitUnblocksTheAccountAndClearsTheReasons(): void
{
$user = (new User())
->setRoles(['ROLE_ADMIN'])
->setRoles(['ROLE_TEAM_ADMIN'])
->setDisabledAt(new \DateTimeImmutable('2026-01-01 08:00:00'))
->setDisabledReason('Für deinen Account liegt in BusPro keine Berechtigung mehr vor.')
->setDisabledReasonInternal('Automatisch gesperrt: keine Rollen in BusPro.')
@@ -135,13 +135,13 @@ class UserTypeTest extends KernelTestCase
$this->assertFalse($user->isDisabled());
$this->assertNull($user->getDisabledReason());
$this->assertNull($user->getDisabledReasonInternal());
$this->assertSame(['ROLE_ADMIN'], $user->getAssignedRoles());
$this->assertSame(['ROLE_TEAM_ADMIN'], $user->getAssignedRoles());
}
public function testSubmitUnblockingClearsTheReasonsEvenWhenTheirFieldsAreStillFilled(): void
{
$user = (new User())
->setRoles(['ROLE_ADMIN'])
->setRoles(['ROLE_TEAM_ADMIN'])
->setDisabledAt(new \DateTimeImmutable('2026-01-01 08:00:00'))
->setDisabledReason('Für deinen Account liegt in BusPro keine Berechtigung mehr vor.')
->setDisabledReasonInternal('Automatisch gesperrt: keine Rollen in BusPro.')