fix: resolve the remaining deprecations reported by phpunit

This commit is contained in:
fromme committed 2026-10-01 10:06:59 +02:00
1 parent 1446211d22
commit da039d0527
7 files changed
+38 -14

No files matched your search

@@ -8,6 +8,7 @@ use App\Form\ApplicationFormSubmissionCallsType;
use App\Model\ApplicationFormSubmissionCallsDto;
use Doctrine\ORM\EntityManagerInterface;
use Psr\Log\LoggerInterface;
use Symfony\Bridge\Doctrine\Attribute\MapEntity;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
@@ -30,8 +31,11 @@ class CallsController extends AbstractController
#[Route('/admin/application-form-submission/calls/{uuid}', name: 'app_admin_application_form_submission_calls', methods: ['POST'])]
#[IsGranted('ROLE_TEAM_ADMIN')]
public function index(ApplicationFormSubmission $submission, Request $request): Response
{
public function index(
#[MapEntity(mapping: ['uuid' => 'uuid'])]
ApplicationFormSubmission $submission,
Request $request,
): Response {
$callsDto = new ApplicationFormSubmissionCallsDto($submission);
$form = $this->createForm(ApplicationFormSubmissionCallsType::class, $callsDto);
@@ -8,6 +8,7 @@ use App\Model\TeamerProvisioningResult;
use App\Service\Teamer\TeamerProvisioner;
use App\Service\Teamer\TeamerProvisioningException;
use Psr\Log\LoggerInterface;
use Symfony\Bridge\Doctrine\Attribute\MapEntity;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
@@ -32,8 +33,11 @@ class CreateTeamerController extends AbstractController
#[Route('/admin/application-form-submission/create-teamer/{uuid}', name: 'app_admin_application_form_submission_create_teamer')]
#[IsGranted('ROLE_TEAM_ADMIN')]
public function index(ApplicationFormSubmission $submission, Request $request): Response
{
public function index(
#[MapEntity(mapping: ['uuid' => 'uuid'])]
ApplicationFormSubmission $submission,
Request $request,
): Response {
if (false === $request->isMethod(Request::METHOD_POST)) {
return $this->render('admin/application_form_submission/modal_create_teamer.html.twig', [
'submission' => $submission,
@@ -7,6 +7,7 @@ use App\Entity\ApplicationFormSubmission;
use App\Htmx\HxRedirectResponse;
use Doctrine\ORM\EntityManagerInterface;
use Psr\Log\LoggerInterface;
use Symfony\Bridge\Doctrine\Attribute\MapEntity;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
@@ -30,8 +31,11 @@ class DeleteController extends AbstractController
#[Route('/admin/application-form-submission/delete/{uuid}', name: 'app_admin_application_form_submission_delete')]
#[IsGranted('ROLE_TEAM_ADMIN')]
public function index(ApplicationFormSubmission $submission, Request $request): Response
{
public function index(
#[MapEntity(mapping: ['uuid' => 'uuid'])]
ApplicationFormSubmission $submission,
Request $request,
): Response {
if (true === $request->isMethod(Request::METHOD_POST)) {
$uuid = $submission->getUuid();
@@ -6,6 +6,7 @@ use App\Controller\Traits\ReturnUrlTrait;
use App\Entity\ApplicationFormSubmission;
use App\Form\ApplicationFormSubmissionCallsType;
use App\Model\ApplicationFormSubmissionCallsDto;
use Symfony\Bridge\Doctrine\Attribute\MapEntity;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
@@ -18,8 +19,11 @@ class DetailController extends AbstractController
#[Route('/admin/application-form-submission/detail/{uuid}', name: 'app_admin_application_form_submission_detail')]
#[IsGranted('ROLE_TEAM_ADMIN')]
public function index(ApplicationFormSubmission $submission, Request $request): Response
{
public function index(
#[MapEntity(mapping: ['uuid' => 'uuid'])]
ApplicationFormSubmission $submission,
Request $request,
): Response {
// Rendered here, taken by CallsController - the form has no validation to fail, so it
// never has to come back to this page with errors.
$callsForm = $this->createForm(
@@ -5,6 +5,7 @@ namespace App\Controller\Admin\ApplicationFormSubmission;
use App\Email\ApplicationFormSubmissionMailer;
use App\Entity\ApplicationFormSubmission;
use App\Htmx\HxRedirectResponse;
use Symfony\Bridge\Doctrine\Attribute\MapEntity;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
@@ -25,8 +26,11 @@ class SendFollowUpMailController extends AbstractController
#[Route('/admin/application-form-submission/send-follow-up/{uuid}', name: 'app_admin_application_form_submission_send_follow_up')]
#[IsGranted('ROLE_TEAM_ADMIN')]
public function index(ApplicationFormSubmission $submission, Request $request): Response
{
public function index(
#[MapEntity(mapping: ['uuid' => 'uuid'])]
ApplicationFormSubmission $submission,
Request $request,
): Response {
if (true === $request->isMethod(Request::METHOD_POST)) {
$this->mailer->sendFollowUp($submission);
@@ -5,6 +5,7 @@ namespace App\Controller\Admin\ApplicationFormSubmission;
use App\Email\ApplicationFormSubmissionMailer;
use App\Entity\ApplicationFormSubmission;
use App\Htmx\HxRedirectResponse;
use Symfony\Bridge\Doctrine\Attribute\MapEntity;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
@@ -24,8 +25,11 @@ class SendReceiptMailController extends AbstractController
#[Route('/admin/application-form-submission/send-receipt/{uuid}', name: 'app_admin_application_form_submission_send_receipt')]
#[IsGranted('ROLE_TEAM_ADMIN')]
public function index(ApplicationFormSubmission $submission, Request $request): Response
{
public function index(
#[MapEntity(mapping: ['uuid' => 'uuid'])]
ApplicationFormSubmission $submission,
Request $request,
): Response {
if (true === $request->isMethod(Request::METHOD_POST)) {
$this->mailer->sendReceipt($submission);