refactor: slim the hotel and country base-data models

This commit is contained in:
fromme committed 2026-09-29 13:06:20 +02:00
1 parent aa66c50979
commit db529d2dc9
5 files changed
+3 -91

No files matched your search

@@ -23,8 +23,8 @@ class HotelDataProviderTest extends TestCase
$this->assertEquals([163959, 11223], array_keys($hotels));
$this->assertEquals('Sportclub Jenatsch', $hotels[163959]->getName());
// MyE&P reports the BusProNet idbuspro as the id, so both properties carry it
$this->assertEquals(163959, $hotels[163959]->getId());
// MyE&P reports the BusProNet idbuspro as its id, and busProId is the only property
// that holds it now - the model used to carry the same number twice
$this->assertEquals(163959, $hotels[163959]->getBusProId());
$this->assertEquals('4711', $hotels[163959]->getCostUnit());
$this->assertEquals('CH', $hotels[163959]->getCountry());
+1 -6
View File
@@ -41,9 +41,6 @@ class ResponseMapperTest extends TestCase
$hotel = $hotels[163959];
$this->assertEquals('Lenzerheide', $hotel->getCity());
$this->assertEquals('Voa Principala 1', $hotel->getStreet());
$this->assertEquals('+41 81 000000', $hotel->getPhone());
$this->assertEquals('4711', $hotel->getCostUnit());
}
@@ -82,8 +79,7 @@ class ResponseMapperTest extends TestCase
$this->assertNull($hotels[1]->getCountryCode());
$this->assertNull($hotels[1]->getCostUnit());
$this->assertNull($hotels[1]->getType());
$this->assertNull($hotels[1]->getPhone());
$this->assertNull($hotels[1]->getName());
}
public function testHotelsWithoutAnIdAreSkipped(): void
@@ -135,7 +131,6 @@ class ResponseMapperTest extends TestCase
$this->assertEquals(['CH'], array_keys($countries));
$this->assertInstanceOf(Country::class, $countries['CH']);
$this->assertEquals(1, $countries['CH']->getId());
$this->assertEquals('Schweiz', $countries['CH']->getName());
$this->assertEquals('CH', $countries['CH']->getToken());
$this->assertEquals('schweizerisch', $countries['CH']->getNationality());