chore: code cleanup

src/BusProNet/ApiClient.php

@@ -31,7 +31,7 @@ class ApiClient
         private readonly ResponseParser $responseParser,
         private readonly LoggerInterface $logger,
         private readonly FilesystemOperator $xmlDump,
-        array $options
+        array $options,
     ) {
         $this->config = $this->resolveOptions($options);
     }

src/BusProNet/ApiClientException.php

@@ -4,4 +4,4 @@ namespace App\BusProNet;
 
 class ApiClientException extends \Exception
 {
-}
+}

src/BusProNet/ApiClientTrait.php

@@ -54,7 +54,7 @@ trait ApiClientTrait
     private function send($socket, string $data): void
     {
         // message length is prepended to actual message
-        $send = sprintf('%010s', strlen($data)) . $data;
+        $send = sprintf('%010s', strlen($data)).$data;
         fwrite($socket, $send);
     }
 
@@ -73,4 +73,4 @@ trait ApiClientTrait
     {
         @fclose($socket);
     }
-}
+}

src/BusProNet/DataProvider/CountryDataProvider.php

@@ -11,7 +11,8 @@ use Symfony\Contracts\Cache\ItemInterface;
 class CountryDataProvider
 {
     public function __construct(private readonly ApiClient $apiClient, private readonly CacheInterface $cache)
-    {}
+    {
+    }
 
     public function getAll(): array
     {
@@ -40,4 +41,4 @@ class CountryDataProvider
 
         return $this->getAll()[$token] ?? null;
     }
-}
+}

src/BusProNet/DataProvider/HotelDataProvider.php

@@ -12,7 +12,8 @@ use Symfony\Contracts\Cache\ItemInterface;
 class HotelDataProvider
 {
     public function __construct(private readonly ApiClient $apiClient, private readonly CacheInterface $cache)
-    {}
+    {
+    }
 
     public function getAll(): array
     {
@@ -50,4 +51,4 @@ class HotelDataProvider
 
         return $hotels;
     }
-}
+}

src/BusProNet/DataProvider/PickupDataProvider.php

@@ -11,7 +11,8 @@ use Symfony\Contracts\Cache\ItemInterface;
 class PickupDataProvider
 {
     public function __construct(private readonly ApiClient $apiClient, private readonly CacheInterface $cache)
-    {}
+    {
+    }
 
     public function getAll(): array
     {
@@ -36,4 +37,4 @@ class PickupDataProvider
     {
         return $this->getAll()[$busProId] ?? null;
     }
-}
+}

src/BusProNet/Model/Address.php

@@ -56,4 +56,4 @@ class Address
 
         return $this;
     }
-}
+}

src/BusProNet/Model/BaseDataResponse.php

@@ -5,10 +5,11 @@ namespace App\BusProNet\Model;
 class BaseDataResponse
 {
     public function __construct(private readonly array $items)
-    {}
+    {
+    }
 
     public function getItems(): array
     {
         return $this->items;
     }
-}
+}

src/BusProNet/Model/Communication.php

@@ -2,8 +2,6 @@
 
 namespace App\BusProNet\Model;
 
-use Symfony\Component\Serializer\Annotation\SerializedName;
-
 class Communication
 {
     private ?string $phone = null;
@@ -45,4 +43,4 @@ class Communication
 
         return $this;
     }
-}
+}

src/BusProNet/Model/Country.php

@@ -56,4 +56,4 @@ class Country
 
         return $this;
     }
-}
+}

src/BusProNet/Model/CrmAttribute.php

@@ -43,4 +43,4 @@ class CrmAttribute
 
         return $this;
     }
-}
+}

src/BusProNet/Model/CrmAttributeGroup.php

@@ -30,4 +30,4 @@ class CrmAttributeGroup
 
         return $this;
     }
-}
+}

src/BusProNet/Model/CrmAttributesResponse.php

@@ -16,7 +16,8 @@ class CrmAttributesResponse
         return $this->attributeGroups;
     }
 
-    public function setAttributeGroups(?array $attributeGroups): static{
+    public function setAttributeGroups(?array $attributeGroups): static
+    {
         $this->attributeGroups = $attributeGroups;
 
         return $this;
@@ -102,4 +103,4 @@ class CrmAttributesResponse
 
         return $crmSelections;
     }
-}
+}

src/BusProNet/Model/NotificationResponse.php

@@ -7,7 +7,7 @@ class NotificationResponse
     private ?int $code;
     private ?string $message;
 
-    public function __construct(int $code = null, string $message = null)
+    public function __construct(?int $code = null, ?string $message = null)
     {
         $this->code = $code;
         $this->message = $message;
@@ -33,9 +33,9 @@ class NotificationResponse
         // These weird and contradictory looking assertions are required because
         // of the stupid API implementation that doesn't distinguish between error
         // and success responses.
-        $responseIsError = 100 <= $this->getCode() || $this->getMessage() === 'Daten konnten nicht gesendet werden.';
+        $responseIsError = 100 <= $this->getCode() || 'Daten konnten nicht gesendet werden.' === $this->getMessage();
         $responseIsSuccess = 650 === $this->getCode() && false === stripos($this->getMessage(), 'fehler');
 
         return false === $responseIsError && true === $responseIsSuccess;
     }
-}
+}

src/BusProNet/Model/Pickup.php

@@ -96,4 +96,4 @@ class Pickup
 
         return $this;
     }
-}
+}

src/BusProNet/Model/ProfileResponse.php

@@ -134,4 +134,4 @@ class ProfileResponse
 
         return $this;
     }
-}
+}

src/BusProNet/ResponseParser.php

@@ -86,7 +86,7 @@ class ResponseParser
         $title = (string) $addressXml->titel;
 
         $gender = (string) $addressXml->geschlecht;
-        $gender = strtoupper($gender) === 'W' ? 'F' : strtoupper($gender);
+        $gender = 'W' === strtoupper($gender) ? 'F' : strtoupper($gender);
 
         $dateString = (string) $addressXml->geburtsdatum;
         $dateOfBirth = empty($dateString) ? null : \DateTimeImmutable::createFromFormat('d.m.Y', $dateString);

src/BusProNet/ResponseParserException.php

@@ -4,4 +4,4 @@ namespace App\BusProNet;
 
 class ResponseParserException extends \Exception
 {
-}
+}

src/BusProNet/UserDataHandler.php

@@ -15,7 +15,7 @@ class UserDataHandler
 {
     public function __construct(
         private readonly EntityManagerInterface $entityManager,
-        private readonly LoggerInterface $logger
+        private readonly LoggerInterface $logger,
     ) {
     }
 
@@ -55,7 +55,7 @@ class UserDataHandler
         array $roles,
         bool $isTeamer = false,
         array $crmSelections = [],
-        array $hotelCodes = []
+        array $hotelCodes = [],
     ): User {
         $user = new User();
         $user
@@ -95,7 +95,7 @@ class UserDataHandler
         array $roles,
         bool $isTeamer = false,
         array $crmSelections = [],
-        array $hotelCodes = []
+        array $hotelCodes = [],
     ): void {
         $user
             ->setEmail($profileResponse->getCommunication()->getEmail())
@@ -126,4 +126,4 @@ class UserDataHandler
 
         $this->entityManager->flush();
     }
-}
+}