chore: code cleanup

This commit is contained in:
Björn Fromme
2025-08-21 14:20:43 +02:00
parent c4e28818e0
commit e36009008c
273 changed files with 547 additions and 531 deletions
@@ -20,7 +20,7 @@ class CreateController extends AbstractController
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -63,4 +63,4 @@ class CreateController extends AbstractController
'returnUrl' => $returnUrl,
]);
}
}
}
@@ -16,7 +16,7 @@ class DeleteController extends AbstractController
{
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -45,4 +45,4 @@ class DeleteController extends AbstractController
'assignment' => $assignment,
]);
}
}
}
@@ -18,7 +18,7 @@ class DetailController extends AbstractController
public function __construct(
private readonly ApplicationRepository $applicationRepository,
private readonly DispositionRepository $dispositionRepository
private readonly DispositionRepository $dispositionRepository,
) {
}
@@ -43,4 +43,4 @@ class DetailController extends AbstractController
'returnUrl' => $this->getReturnUrl($request, 'app_administrative_assignment_index'),
]);
}
}
}
@@ -19,7 +19,7 @@ class DuplicateController extends AbstractController
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -64,4 +64,4 @@ class DuplicateController extends AbstractController
'returnUrl' => $returnUrl,
]);
}
}
}
@@ -19,7 +19,7 @@ class EditController extends AbstractController
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -58,4 +58,4 @@ class EditController extends AbstractController
'returnUrl' => $returnUrl,
]);
}
}
}
@@ -16,7 +16,7 @@ class IndexController extends AbstractController
public function __construct(
private readonly AssignmentRepository $assignmentRepository,
private readonly PaginatorInterface $paginator,
private readonly AssignmentFilterHandler $filterHandler
private readonly AssignmentFilterHandler $filterHandler,
) {
}
@@ -46,4 +46,4 @@ class IndexController extends AbstractController
'filterDto' => $filterDto,
]);
}
}
}
@@ -28,4 +28,4 @@ class PickupFormController extends AbstractController
]
);
}
}
}
@@ -15,7 +15,7 @@ class TimelineController extends AbstractController
public function __construct(
private readonly AssignmentRepository $assignmentRepository,
private readonly TimelineService $timelineService,
private readonly TimelineFilterHandler $filterHandler
private readonly TimelineFilterHandler $filterHandler,
) {
}
@@ -14,7 +14,7 @@ class IndexController extends AbstractController
{
public function __construct(
private readonly AvailabilityRepository $availabilityRepository,
private readonly PaginatorInterface $paginator
private readonly PaginatorInterface $paginator,
) {
}
@@ -41,4 +41,4 @@ class IndexController extends AbstractController
'pagination' => $pagination,
]);
}
}
}
@@ -85,7 +85,7 @@ class DocumentUploadController extends AbstractController
->setApprovedBy($user->getInitials())
;
$disposition
$disposition
->addDocument($upload)
->setStatus(Disposition::STATUS_CONFIRMED)
;
@@ -17,7 +17,7 @@ class SpecialAgreementsController extends AbstractController
{
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -97,7 +97,7 @@ class CheckController extends AbstractController
]);
}
private function rejectDocument(Upload $document, string $comment = null): void
private function rejectDocument(Upload $document, ?string $comment = null): void
{
$document
->setStatus(Upload::STATUS_REJECTED)
@@ -16,7 +16,7 @@ class DeleteController extends AbstractController
{
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -42,4 +42,4 @@ class DeleteController extends AbstractController
'document' => $document,
]);
}
}
}
@@ -17,7 +17,7 @@ class IndexController extends AbstractController
public function __construct(
private readonly UploadRepository $uploadRepository,
private readonly PaginatorInterface $paginator,
private readonly DocumentFilterHandler $filterHandler
private readonly DocumentFilterHandler $filterHandler,
) {
}
@@ -10,7 +10,6 @@ use Symfony\Component\Security\Http\Attribute\IsGranted;
class DetailController extends AbstractController
{
#[Route('/administrative/feedback/detail/{uuid}', name: 'app_administrative_feedback_detail')]
#[IsGranted('ROLE_ADMINISTRATIVE')]
public function index(Feedback $feedback): Response
@@ -19,4 +18,4 @@ class DetailController extends AbstractController
'feedback' => $feedback,
]);
}
}
}
@@ -16,7 +16,7 @@ class IndexController extends AbstractController
public function __construct(
private readonly FeedbackFilterHandler $filterHandler,
private readonly FeedbackRepository $feedbackRepository,
private readonly PaginatorInterface $paginator
private readonly PaginatorInterface $paginator,
) {
}
@@ -46,4 +46,4 @@ class IndexController extends AbstractController
'filterDto' => $filterDto,
]);
}
}
}
@@ -22,7 +22,7 @@ class ProvideController extends AbstractController
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly EventDispatcherInterface $eventDispatcher
private readonly EventDispatcherInterface $eventDispatcher,
) {
}
@@ -83,4 +83,4 @@ class ProvideController extends AbstractController
'disposition' => $disposition,
]);
}
}
}
@@ -16,7 +16,7 @@ class ProfileController extends AbstractController
{
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -44,4 +44,4 @@ class ProfileController extends AbstractController
'form' => $form->createView(),
]);
}
}
}
@@ -23,7 +23,7 @@ class CreateController extends AbstractController
private readonly EntityManagerInterface $entityManager,
private readonly HotelDataProvider $hotelDataProvider,
private readonly PickupDataProvider $pickupDataProvider,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -57,4 +57,4 @@ class CreateController extends AbstractController
'form' => $form->createView(),
]);
}
}
}
@@ -16,7 +16,7 @@ class DeleteController extends AbstractController
{
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -42,4 +42,4 @@ class DeleteController extends AbstractController
'destination' => $destination,
]);
}
}
}
@@ -19,7 +19,7 @@ class DuplicateController extends AbstractController
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly HotelDataProvider $hotelDataProvider,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -65,4 +65,4 @@ class DuplicateController extends AbstractController
'form' => $form->createView(),
]);
}
}
}
@@ -22,7 +22,7 @@ class EditController extends AbstractController
private readonly EntityManagerInterface $entityManager,
private readonly HotelDataProvider $hotelDataProvider,
private readonly PickupDataProvider $pickupDataProvider,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -52,4 +52,4 @@ class EditController extends AbstractController
'form' => $form->createView(),
]);
}
}
}
@@ -16,7 +16,7 @@ class IndexController extends AbstractController
public function __construct(
private readonly DestinationRepository $destinationRepository,
private readonly PaginatorInterface $paginator,
private readonly DestinationFilterHandler $filterHandler
private readonly DestinationFilterHandler $filterHandler,
) {
}
@@ -46,4 +46,4 @@ class IndexController extends AbstractController
'filterDto' => $filterDto,
]);
}
}
}
@@ -16,7 +16,7 @@ class DeleteController extends AbstractController
{
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -42,4 +42,4 @@ class DeleteController extends AbstractController
'document' => $document,
]);
}
}
}
@@ -17,7 +17,7 @@ class EditController extends AbstractController
{
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -57,4 +57,4 @@ class EditController extends AbstractController
'form' => $form->createView(),
]);
}
}
}
@@ -14,7 +14,7 @@ class IndexController extends AbstractController
{
public function __construct(
private readonly UploadRepository $uploadRepository,
private readonly PaginatorInterface $paginator
private readonly PaginatorInterface $paginator,
) {
}
@@ -38,4 +38,4 @@ class IndexController extends AbstractController
'pagination' => $pagination,
]);
}
}
}
@@ -19,7 +19,7 @@ class ReplaceController extends AbstractController
public function __construct(
private readonly UploadHandler $uploadHandler,
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -61,4 +61,4 @@ class ReplaceController extends AbstractController
'form' => $form->createView(),
]);
}
}
}
@@ -19,7 +19,7 @@ class UploadController extends AbstractController
public function __construct(
private readonly UploadHandler $uploadHandler,
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -51,7 +51,7 @@ class UploadController extends AbstractController
if ($form->isSubmitted() && $form->isValid()) {
$count = count($uploadedDocuments);
$this->addFlash('success', $count === 1 ? 'Das Dokument wurde hochgeladen' : 'Die Dokumente wurden hochgeladen');
$this->addFlash('success', 1 === $count ? 'Das Dokument wurde hochgeladen' : 'Die Dokumente wurden hochgeladen');
$loggerContext = [];
foreach ($uploadedDocuments as $document) {
$loggerContext[] = [
@@ -68,4 +68,4 @@ class UploadController extends AbstractController
'form' => $form->createView(),
]);
}
}
}
@@ -16,7 +16,7 @@ class CreateController extends AbstractController
{
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -45,4 +45,4 @@ class CreateController extends AbstractController
'form' => $form->createView(),
]);
}
}
}
@@ -16,7 +16,7 @@ class DeleteController extends AbstractController
{
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -41,4 +41,4 @@ class DeleteController extends AbstractController
'faq' => $faq,
]);
}
}
}
@@ -16,7 +16,7 @@ class EditController extends AbstractController
{
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -43,4 +43,4 @@ class EditController extends AbstractController
'form' => $form->createView(),
]);
}
}
}
@@ -16,7 +16,7 @@ class IndexController extends AbstractController
{
public function __construct(
private readonly FaqRepository $faqRepository,
private readonly EntityManagerInterface $entityManager
private readonly EntityManagerInterface $entityManager,
) {
}
@@ -51,4 +51,4 @@ class IndexController extends AbstractController
'success' => true,
]);
}
}
}
@@ -17,7 +17,7 @@ class CreateController extends AbstractController
{
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -47,4 +47,4 @@ class CreateController extends AbstractController
'form' => $form->createView(),
]);
}
}
}
@@ -16,7 +16,7 @@ class DeleteController extends AbstractController
{
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -40,4 +40,4 @@ class DeleteController extends AbstractController
'news' => $news,
]);
}
}
}
@@ -17,7 +17,7 @@ class EditController extends AbstractController
{
public function __construct(
private readonly EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger
private readonly LoggerInterface $logger,
) {
}
@@ -46,4 +46,4 @@ class EditController extends AbstractController
'form' => $form->createView(),
]);
}
}
}
@@ -33,4 +33,4 @@ class IndexController extends AbstractController
'activeNews' => $activeNews,
]);
}
}
}
@@ -20,7 +20,7 @@ class IndexController extends AbstractController
protected readonly TeamerFilterHandler $filterHandler,
private readonly TeamerRepository $teamerRepository,
private readonly PaginatorInterface $paginator,
private readonly EntityManagerInterface $entityManager
private readonly EntityManagerInterface $entityManager,
) {
}
@@ -56,4 +56,4 @@ class IndexController extends AbstractController
return new HxRedirectResponse($this->generateUrl('app_administrative_teamer_index'));
}
}
}
@@ -17,7 +17,8 @@ class InfoController extends AbstractController
use ReturnUrlTrait;
public function __construct(private readonly DispositionRepository $dispositionRepository)
{}
{
}
#[Route('/administrative/teamer/info/{uuid}', name: 'app_administrative_teamer_info')]
#[IsGranted(new Expression('is_granted("ROLE_ADMINISTRATIVE") or is_granted("ROLE_HOUSE_MANAGER")'))]
@@ -33,4 +34,4 @@ class InfoController extends AbstractController
'returnUrl' => $returnUrl,
]);
}
}
}
@@ -35,4 +35,4 @@ class ProfileController extends AbstractController
'returnUrl' => $returnUrl,
]);
}
}
}
@@ -15,7 +15,7 @@ class RecentAssignmentsController extends AbstractController
{
public function __construct(
private readonly DispositionRepository $dispositionRepository,
private readonly PaginatorInterface $paginator
private readonly PaginatorInterface $paginator,
) {
}
@@ -38,10 +38,9 @@ class RecentAssignmentsController extends AbstractController
]
);
return $this->render('administrative/teamer/recent_assignments.html.twig', [
'teamer' => $teamer,
'pagination' => $pagination,
]);
}
}
}