feat: keep questionnaires until submitted, remind teamers daily and take bus feedback per leg

This commit is contained in:
fromme committed 2026-11-10 16:38:51 +01:00
1 parent abf9c1be0b
commit e72616fdbf
37 files changed
+1119 -238

No files matched your search

@@ -9,6 +9,7 @@ use App\Entity\Assignment;
use App\Entity\Disposition;
use App\Entity\QuestionnaireResponse;
use App\Entity\Teamer;
use App\Enum\BusLeg;
use App\Enum\ConditionOperator;
use App\Enum\QuestionnaireResponseStatus;
use App\Enum\QuestionType;
@@ -81,6 +82,28 @@ class QuestionnaireResponseTest extends TestCase
$this->response()->submit($this->definition(key: 'other'), [], [], new \DateTimeImmutable());
}
/**
* The bus feedback is one response per escorted leg; any other questionnaire one per
* placement - a leg there would slip past the unique key.
*/
public function testALegIsRequiredExactlyForAPerBusLegQuestionnaire(): void
{
$disposition = new Disposition(new Application(new Assignment(), new Teamer()));
$perLeg = new Definition('bus_feedback', 1, 'Bus-Feedback', null, [], perBusLeg: true);
$this->assertSame(BusLeg::RETURN, QuestionnaireResponse::forDisposition($perLeg, $disposition, BusLeg::RETURN)->getLeg());
$this->assertNull(QuestionnaireResponse::forDisposition($this->definition(), $disposition)->getLeg());
foreach ([[$perLeg, null], [$this->definition(), BusLeg::OUTBOUND]] as [$definition, $leg]) {
try {
QuestionnaireResponse::forDisposition($definition, $disposition, $leg);
$this->fail(sprintf('"%s" accepted leg %s', $definition->key, $leg?->value ?? 'none'));
} catch (\LogicException) {
$this->addToAssertionCount(1);
}
}
}
private function response(): QuestionnaireResponse
{
$disposition = new Disposition(new Application(new Assignment(), new Teamer()));