Feat: Extend and apply voter for checking of uploaded documents

src/Controller/Admin/Document/CheckController.php

@@ -31,6 +31,7 @@ class CheckController extends AbstractController
 
     #[Route('/admin/document/check/{uuid}', name: 'app_admin_document_check')]
     #[IsGranted('ROLE_ADMINISTRATIVE')]
+    #[IsGranted('CHECK', subject: 'document')]
     public function index(Upload $document, Request $request): JsonResponse
     {
         $response = new AjaxModalResponseDto();

src/Security/Voter/UploadVoter.php

@@ -4,7 +4,6 @@ namespace App\Security\Voter;
 
 use App\Entity\Upload;
 use App\Entity\User;
-use Symfony\Bundle\SecurityBundle\Security;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Core\Authorization\Voter\Voter;
 
@@ -13,9 +12,7 @@ class UploadVoter extends Voter
     public const VIEW = 'VIEW';
     public const DELETE = 'DELETE';
     public const DOWNLOAD = 'DOWNLOAD';
-
-    public function __construct(private readonly Security $security)
-    {}
+    public const CHECK = 'CHECK';
 
     protected function supports(string $attribute, mixed $subject): bool
     {
@@ -23,21 +20,32 @@ class UploadVoter extends Voter
             return false;
         }
 
-        return in_array($attribute, [static::VIEW, static::DELETE, static::DOWNLOAD]);
+        return in_array($attribute, [static::VIEW, static::DELETE, static::DOWNLOAD, static::CHECK]);
     }
 
     protected function voteOnAttribute(string $attribute, mixed $subject, TokenInterface $token): bool
     {
-        if (true === $this->security->isGranted('ROLE_ADMINISTRATIVE')) {
-            return true;
-        }
-
         /** @var Upload $upload */
         $upload = $subject;
 
-        /** @var User $user */
-        $user = $this->security->getUser();
+        // Administrative users have full access
+        if (true === in_array('ROLE_ADMINISTRATIVE', $token->getRoleNames())) {
+            // Only new documents may be checked
+            if (static::CHECK === $attribute) {
+                return Upload::STATUS_NEW === $upload->getStatus();
+            }
 
-        return $upload->getOwner() === $user;
+            return true;
+        }
+
+        // Teamers may only access their own documents
+        if (true === in_array($attribute, [static::VIEW, static::DELETE, static::DOWNLOAD])) {
+            /** @var User $user */
+            $user = $token->getUser();
+
+            return $upload->getOwner() === $user;
+        }
+
+        return false;
     }
 }