From facf7e7718dea7b15523a06cc3197742c27d0ac6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Fromme?= <fromme@dreipunktnull.com>
Date: Wed, 27 Nov 2024 11:44:28 +0100
Subject: [PATCH] fix: ignore deleted and called off assignments for feedback
 todos

---
 src/Repository/DispositionRepository.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/Repository/DispositionRepository.php b/src/Repository/DispositionRepository.php
index 1cec5e7..826cfee 100644
--- a/src/Repository/DispositionRepository.php
+++ b/src/Repository/DispositionRepository.php
@@ -182,6 +182,7 @@ class DispositionRepository extends ServiceEntityRepository
             ->innerJoin('assignment.destination', 'destination')
             ->leftJoin('disposition.feedback', 'feedback')
             ->where($qb->expr()->andX(
+                $qb->expr()->notIn('assignment.status', ':status'),
                 $qb->expr()->orX(
                     $qb->expr()->andX(
                         $qb->expr()->isNotNull('assignment.dateTo'),
@@ -191,6 +192,7 @@ class DispositionRepository extends ServiceEntityRepository
                 ),
                 $qb->expr()->isNull('feedback')
             ))
+            ->setParameter('status', [Assignment::STATUS_CALLED_OFF, Assignment::STATUS_DELETED])
             ->setParameter('dateTo', new \DateTimeImmutable())
         ;