From 00df76269a5dcb8841bf950586a6ebb598c1f338 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Fromme?= Date: Tue, 17 Mar 2026 09:44:50 +0100 Subject: [PATCH] chore: cleanup after master flatten rewrite --- docs/technical-documentation.md | 7 +++---- src/BusProNet/XmlParser/BookingsParser.php | 1 - 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/docs/technical-documentation.md b/docs/technical-documentation.md index 5249632..e25e796 100644 --- a/docs/technical-documentation.md +++ b/docs/technical-documentation.md @@ -886,10 +886,9 @@ Keys stored in `config/secret/` directory. **Location:** `src/Security/Voter/BookingVoter.php` -| Operation | Requirements | -|-----------|--------------| -| `VIEW` | User owns booking (addressId match) | -| `EDIT` | User owns booking AND booking is editable | +This voter currently exists as legacy authorization logic and is not actively invoked by booking controllers. + +Current booking routes (`/bookings/*`) are guarded with `ROLE_USER`, while final document access checks are enforced by BusProNet. ### 7.4 OAuth2 diff --git a/src/BusProNet/XmlParser/BookingsParser.php b/src/BusProNet/XmlParser/BookingsParser.php index 33eafa2..abedfec 100644 --- a/src/BusProNet/XmlParser/BookingsParser.php +++ b/src/BusProNet/XmlParser/BookingsParser.php @@ -21,7 +21,6 @@ class BookingsParser extends AbstractParser $booking = new Booking(); $booking->id = $this->getIntOrNullValue($node->filterXPath('//id')); - $booking->applicantId = $this->getIntOrNullValue($node->filterXPath('//idadresse_anmelder')); $booking->bookingNumber = $this->getIntOrNullValue($node->filterXPath('//vorgangsnummer')); $booking->status = $this->getStringOrNullValue($node->filterXPath('//status')); $booking->participantCount = $this->getIntOrNullValue($node->filterXPath('//personen'));