feat: enforce profile data completeness before entering booking flow

This commit is contained in:
Björn Fromme
2026-03-16 12:02:59 +01:00
parent 18d60c8781
commit 0a0987873f
7 changed files with 235 additions and 19 deletions
@@ -1,5 +1,7 @@
<?php
declare(strict_types=1);
namespace App\Controller\Account;
use App\BusProNet\ApiClient;
@@ -7,9 +9,11 @@ use App\BusProNet\Exception\ApiClientException;
use App\BusProNet\Model\Notification;
use App\BusProNet\Model\PersonalData;
use App\Entity\User;
use App\EventSubscriber\ProfileCompletionSubscriber;
use App\Form\PersonalDataType;
use App\Security\Crypt;
use App\Service\BookingEditDataLoaderService;
use App\Service\ProfileCompletenessChecker;
use Psr\Log\LoggerInterface;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
@@ -27,15 +31,17 @@ use Symfony\Component\Security\Http\Attribute\IsGranted;
class PersonalDataController extends AbstractController
{
/**
* @param ApiClient $apiClient BusProNet API client for data operations
* @param Crypt $crypt Encryption service for password handling
* @param BookingEditDataLoaderService $dataLoader Data loader for cache invalidation
* @param LoggerInterface $logger Logger for audit trails and debugging
* @param ApiClient $apiClient BusProNet API client for data operations
* @param Crypt $crypt Encryption service for password handling
* @param BookingEditDataLoaderService $dataLoader Data loader for cache invalidation
* @param ProfileCompletenessChecker $completenessChecker Profile validation service
* @param LoggerInterface $logger Logger for audit trails and debugging
*/
public function __construct(
private readonly ApiClient $apiClient,
private readonly Crypt $crypt,
private readonly BookingEditDataLoaderService $dataLoader,
private readonly ProfileCompletenessChecker $completenessChecker,
private readonly LoggerInterface $logger,
) {
}
@@ -98,6 +104,16 @@ class PersonalDataController extends AbstractController
$this->logger->info('Updated personal data', [
'email' => $user->getEmail(),
]);
// Handle profile completion redirect
$session = $request->getSession();
$redirectUrl = $session->get(ProfileCompletionSubscriber::SESSION_REDIRECT_KEY);
if (null !== $redirectUrl && true === $this->completenessChecker->isComplete($personalData)) {
$session->remove(ProfileCompletionSubscriber::SESSION_REDIRECT_KEY);
return $this->redirect($redirectUrl);
}
} catch (ApiClientException $e) {
$this->addFlash('error', $e->getMessage());
}