diff --git a/config/services.yaml b/config/services.yaml index 7836f0e..290b05e 100644 --- a/config/services.yaml +++ b/config/services.yaml @@ -6,6 +6,7 @@ parameters: travel_info_base_url: '%env(APP_TRAVEL_INFO_BASE_URL)%' path_to_keys: '%kernel.project_dir%/config/secret' + bpn_debug: '%env(APP_BPN_DEBUG)%' services: # default configuration for services in *this* file diff --git a/src/BusProNet/ApiClient.php b/src/BusProNet/ApiClient.php index 9548b78..ea644ce 100644 --- a/src/BusProNet/ApiClient.php +++ b/src/BusProNet/ApiClient.php @@ -121,7 +121,7 @@ class ApiClient 'adressdaten' => $personalData->toPayload(), ]; - return $this->sendRequest(static::TYPE_CUSTOMER_DATA, $data, $debug); + return $this->sendRequest(static::TYPE_CUSTOMER_DATA, $data); } /** @@ -184,7 +184,7 @@ class ApiClient /** * @throws ApiClientException */ - public function updateBooking(BookingData $formData, bool $debug = false): Notification|BookingUpdate + public function updateBooking(BookingData $formData): Notification|BookingUpdate { $payload = (new BookingDataProcessor())->createUpdateRequestPayload($formData); @@ -196,7 +196,7 @@ class ApiClient ...$payload, ]; - return $this->sendRequest(static::TYPE_BOOKING_UPDATE, $data, $debug); + return $this->sendRequest(static::TYPE_BOOKING_UPDATE, $data); } /** @@ -282,9 +282,10 @@ class ApiClient /** * @throws ApiClientException */ - private function sendRequest(string $type, array $data, bool $debug = false): mixed + private function sendRequest(string $type, array $data): mixed { $requestId = date(DATE_ATOM).uniqid(); + $debug = $this->config['debug']; $body = $this ->serializer diff --git a/src/BusProNet/Model/Booking.php b/src/BusProNet/Model/Booking.php index 1e94cdc..cbb921c 100644 --- a/src/BusProNet/Model/Booking.php +++ b/src/BusProNet/Model/Booking.php @@ -146,6 +146,8 @@ class Booking public function isEditable(): bool { - return $this->travelDate > new \DateTimeImmutable() && false === in_array($this->status, ['S', 'U']); + $now = new \DateTimeImmutable(); + + return $this->travelDate > $now && false === in_array($this->status, ['S', 'U']); } } diff --git a/src/Controller/Booking/EditController.php b/src/Controller/Booking/EditController.php index 4bed922..9e1ba6d 100644 --- a/src/Controller/Booking/EditController.php +++ b/src/Controller/Booking/EditController.php @@ -105,7 +105,7 @@ class EditController extends AbstractController ]); try { - $response = $this->apiClient->updateBooking($formData, true); + $response = $this->apiClient->updateBooking($formData); if ($response instanceof Notification) { if (true === $response->isError()) { $this->addFlash('error', $response->message);