chore: code cleanup with rector and php-cs-fixer

src/Controller/Account/PersonalDataController.php

@@ -10,12 +10,12 @@ use App\BusProNet\Model\Notification;
 use App\BusProNet\Model\PersonalData;
 use App\Entity\User;
 use App\Exception\NewsletterProviderException;
-use App\Htmx\HxTrait;
 use App\Form\PersonalDataType;
+use App\Htmx\HxTrait;
 use App\Model\NewsletterSubscriptionRequestResult;
-use App\Service\NewsletterManager;
 use App\Security\Crypt;
 use App\Service\BookingEditDataLoader;
+use App\Service\NewsletterManager;
 use App\Service\ProfileCompletenessChecker;
 use Doctrine\ORM\EntityManagerInterface;
 use Psr\Log\LoggerInterface;
@@ -39,24 +39,23 @@ class PersonalDataController extends AbstractController
     public const SESSION_REDIRECT_KEY = '_profile_completion_redirect';
 
     /**
-     * @param ApiClient $apiClient BusProNet API client for data operations
-     * @param Crypt $crypt Encryption service for password handling
-     * @param BookingEditDataLoader $dataLoader Data loader for cache invalidation
+     * @param ApiClient                  $apiClient           BusProNet API client for data operations
+     * @param Crypt                      $crypt               Encryption service for password handling
+     * @param BookingEditDataLoader      $dataLoader          Data loader for cache invalidation
      * @param ProfileCompletenessChecker $completenessChecker Profile validation service
-     * @param EntityManagerInterface $entityManager Entity manager for persisting user changes
-     * @param NewsletterManager $newsletterManager Newsletter confirmation service
-     * @param LoggerInterface $logger Logger for audit trails and debugging
+     * @param EntityManagerInterface     $entityManager       Entity manager for persisting user changes
+     * @param NewsletterManager          $newsletterManager   Newsletter confirmation service
+     * @param LoggerInterface            $logger              Logger for audit trails and debugging
      */
     public function __construct(
-        private readonly ApiClient                  $apiClient,
-        private readonly Crypt                      $crypt,
-        private readonly BookingEditDataLoader      $dataLoader,
+        private readonly ApiClient $apiClient,
+        private readonly Crypt $crypt,
+        private readonly BookingEditDataLoader $dataLoader,
         private readonly ProfileCompletenessChecker $completenessChecker,
-        private readonly EntityManagerInterface     $entityManager,
-        private readonly NewsletterManager          $newsletterManager,
-        private readonly LoggerInterface            $logger,
-    )
-    {
+        private readonly EntityManagerInterface $entityManager,
+        private readonly NewsletterManager $newsletterManager,
+        private readonly LoggerInterface $logger,
+    ) {
     }
 
     /**
@@ -125,7 +124,7 @@ class PersonalDataController extends AbstractController
 
         return $this->render('account/personal_data.html.twig', [
             'personalData' => $personalData,
-            'personalDataForm' => $personalDataForm->createView(),
+            'personalDataForm' => $personalDataForm,
             'newsletterSubscribed' => $newsletterSubscribed,
             'newsletterPendingConfirmation' => $newsletterPendingConfirmation,
         ]);
@@ -149,7 +148,6 @@ class PersonalDataController extends AbstractController
                 $result = $this->newsletterManager->requestDefaultListSubscription($email, $personalData->firstName, $personalData->name);
                 $this->addFlash(...$this->newsletterRequestFlash($result));
             }
-
         } catch (NewsletterProviderException|\InvalidArgumentException $e) {
             $this->addFlash('error', 'Die Newsletter-Aktion konnte gerade nicht verarbeitet werden. Bitte versuche es erneut.');
             $this->logger->warning('Newsletter action failed', [

src/Controller/Api/NewsletterSubscriptionController.php

@@ -32,7 +32,7 @@ class NewsletterSubscriptionController extends AbstractController
     }
 
     #[Route('/newsletters', name: 'api_newsletters_all', methods: ['GET'])]
-    public function index():JsonResponse
+    public function index(): JsonResponse
     {
         return $this->json($this->newsletterManager->createListIdMapping(array_keys($this->mailjetLists)));
     }

src/Controller/Booking/Create/Step1Controller.php

@@ -85,7 +85,7 @@ class Step1Controller extends AbstractBookingCreateController
 
         return $this->render('booking/create/step_1.html.twig', [
             'bookingCreateContext' => $context,
-            'form' => $form->createView(),
+            'form' => $form,
         ]);
     }
 

src/Controller/Booking/Create/Step2Controller.php

@@ -5,10 +5,10 @@ declare(strict_types=1);
 namespace App\Controller\Booking\Create;
 
 use App\BusProNet\Model\Travel;
+use App\Entity\User;
 use App\Exception\BookingSessionNotFoundException;
 use App\Exception\HotelNotInTravelException;
 use App\Exception\TravelNotFoundException;
-use App\Entity\User;
 use App\Form\BookingCreateStep2Type;
 use App\Form\Model\BookingDto;
 use App\Form\Model\ParticipantDto;

src/Controller/Booking/Create/Step2ParticipantController.php

@@ -136,7 +136,7 @@ class Step2ParticipantController extends AbstractController
         );
 
         return $this->render('booking/create/step_2_participant.html.twig', [
-            'form' => $form->createView(),
+            'form' => $form,
             'participantIndex' => $index,
             'bookingCreateContext' => $bookingCreateContext,
             'bookingDto' => $bookingCreateContext->bookingDto,

src/Controller/Booking/Create/Step3Controller.php

@@ -228,7 +228,7 @@ class Step3Controller extends AbstractBookingCreateController
 
         return $this->render('booking/create/step_3.html.twig', [
             'bookingCreateContext' => $context,
-            'form' => $form->createView(),
+            'form' => $form,
         ]);
     }
 

src/Controller/Booking/Create/Step4Controller.php

@@ -182,7 +182,7 @@ class Step4Controller extends AbstractBookingCreateController
 
         return $this->render('booking/create/step_4.html.twig', [
             'bookingCreateContext' => $bookingCreateContext,
-            'form' => $form->createView(),
+            'form' => $form,
             'newsletterOptInVisible' => $newsletterOptInVisible,
             'newsletterTargetEmail' => $newsletterTargetEmail,
         ]);

src/Controller/Booking/Edit/IndexController.php

@@ -9,8 +9,8 @@ use App\Entity\User;
 use App\Exception\TravelNotFoundException;
 use App\Form\BookingEditType;
 use App\Form\Model\BookingDto;
-use App\Model\BookingEditSubmissionResult;
 use App\Htmx\HxTrait;
+use App\Model\BookingEditSubmissionResult;
 use App\Service\BookingChangeTracker;
 use App\Service\BookingEditContextFactory;
 use App\Service\BookingEditDataLoader;

src/Controller/Booking/Edit/ParticipantController.php

@@ -99,7 +99,7 @@ class ParticipantController extends AbstractController
         $context = $this->editContextFactory->createParticipantContext($bookingDto, $bookingData);
 
         return $this->render('booking/edit/participant.html.twig', [
-            'form' => $form->createView(),
+            'form' => $form,
             'participantIndex' => $index,
             'bookingEditContext' => $context,
             'bookingDto' => $context->bookingDto,

src/Controller/RegistrationController.php

@@ -55,7 +55,7 @@ class RegistrationController extends AbstractController
         }
 
         return $this->render('registration/index.html.twig', [
-            'form' => $form->createView(),
+            'form' => $form,
         ]);
     }
 }

src/Controller/ResetPasswordController.php

@@ -63,7 +63,7 @@ class ResetPasswordController extends AbstractController
         }
 
         return $this->render('reset_password/index.html.twig', [
-            'form' => $form->createView(),
+            'form' => $form,
         ]);
     }
 }

src/Controller/Webhook/MailjetNewsletterWebhookController.php

@@ -55,6 +55,7 @@ final class MailjetNewsletterWebhookController extends AbstractController
      * into a list before dispatching.
      *
      * @param array<int|string, mixed> $payload
+     *
      * @return list<array<string, mixed>>
      */
     private function normalizeEvents(array $payload): array