feat: additional status

2026-08-04 18:09:40 +02:00
parent dc86e715cb
commit 2c381ee741
20 changed files with 588 additions and 64 deletions
@@ -0,0 +1,114 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Tests\Form\Admin\Groups;
+
+use App\Entity\Groups\AccommodationBooking;
+use App\Enum\Groups\AccommodationBookingStatus;
+use App\Form\Admin\Groups\AccommodationBookingType;
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\Form\FormInterface;
+use Symfony\Component\OptionsResolver\OptionsResolver;
+use Symfony\Component\Validator\Constraints\Email;
+use Symfony\Component\Validator\Constraints\EmailValidator;
+use Symfony\Component\Validator\ConstraintValidatorFactory;
+use Symfony\Component\Validator\Validation;
+
+class AccommodationBookingTypeTest extends TestCase
+{
+    /**
+     * @dataProvider statusesWithoutMandatoryFields
+     */
+    public function testDraftAndDiscardedAreValidatedWithoutTheEditGroup(AccommodationBookingStatus $status): void
+    {
+        self::assertSame(['Default'], $this->resolveValidationGroups($status));
+    }
+
+    /**
+     * @dataProvider customerFacingStatuses
+     */
+    public function testCustomerFacingStatusesAddTheEditGroup(AccommodationBookingStatus $status): void
+    {
+        self::assertSame(['Default', 'edit'], $this->resolveValidationGroups($status));
+    }
+
+    /**
+     * @return iterable<string, array{AccommodationBookingStatus}>
+     */
+    public static function statusesWithoutMandatoryFields(): iterable
+    {
+        yield 'draft' => [AccommodationBookingStatus::Draft];
+        yield 'discarded' => [AccommodationBookingStatus::Discarded];
+    }
+
+    /**
+     * @return iterable<string, array{AccommodationBookingStatus}>
+     */
+    public static function customerFacingStatuses(): iterable
+    {
+        yield 'inquiry' => [AccommodationBookingStatus::Inquiry];
+        yield 'booking' => [AccommodationBookingStatus::Booking];
+    }
+
+    /**
+     * @dataProvider statusesWithoutMandatoryFields
+     */
+    public function testEmptyContactDataPassesValidation(AccommodationBookingStatus $status): void
+    {
+        $booking = new AccommodationBooking();
+        $booking->setStatus($status);
+
+        $violations = $this->validate($booking, $this->resolveValidationGroups($status));
+
+        self::assertCount(0, $violations);
+    }
+
+    public function testPromotedBookingRequiresContactData(): void
+    {
+        $booking = new AccommodationBooking();
+        $booking->setStatus(AccommodationBookingStatus::Inquiry);
+
+        $violations = $this->validate($booking, ['Default', 'edit']);
+
+        $properties = array_map(static fn ($violation) => $violation->getPropertyPath(), iterator_to_array($violations));
+        sort($properties);
+
+        self::assertSame(['email', 'firstName', 'groupName', 'lastName'], $properties);
+    }
+
+    /**
+     * @return string[]
+     */
+    private function resolveValidationGroups(AccommodationBookingStatus $status): array
+    {
+        $resolver = new OptionsResolver();
+        (new AccommodationBookingType())->configureOptions($resolver);
+
+        $booking = new AccommodationBooking();
+        $booking->setStatus($status);
+
+        $form = $this->createMock(FormInterface::class);
+        $form->method('getData')->willReturn($booking);
+
+        return ($resolver->resolve()['validation_groups'])($form);
+    }
+
+    /**
+     * @param string[] $groups
+     */
+    private function validate(AccommodationBooking $booking, array $groups): \Symfony\Component\Validator\ConstraintViolationListInterface
+    {
+        // The app configures email_validation_mode: html5 globally (config/packages/validator.yaml);
+        // the standalone builder would otherwise fall back to the deprecated "loose" mode.
+        $validatorFactory = new ConstraintValidatorFactory([
+            EmailValidator::class => new EmailValidator(Email::VALIDATION_MODE_HTML5),
+        ]);
+
+        return Validation::createValidatorBuilder()
+            ->enableAttributeMapping()
+            ->setConstraintValidatorFactory($validatorFactory)
+            ->getValidator()
+            ->validate($booking, null, $groups);
+    }
+}