EP/myep
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: properly assign readonly state to form fields for unavailable services

Browse Source
This commit is contained in:
Björn Fromme
2026-03-16 12:00:56 +01:00
parent 96619c6cec
commit 3984a623bf
14 changed files with 68 additions and 140 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Service/ParticipantEligibilityService.php
+1 -1
View File
@@ -64,7 +64,7 @@ class ParticipantEligibilityService
return true;
}
$allSkiPasses = $bookingDto->travel->getAdditionalServicesBySubTypes(Constants::TOKEN_SKI_PASS, true, true);
$allSkiPasses = $bookingDto->travel->getAdditionalServicesBySubTypes(Constants::TOKEN_SKI_PASS, true);
$availableSkiPasses = array_filter(
$allSkiPasses,
fn (Service $service) => $this->isSkiPassAvailableForParticipant($service, $bookingDto, $participantIndex)
src/Service/ServiceAvailabilityCalculator.php
+22 -6
View File
@@ -63,12 +63,17 @@ class ServiceAvailabilityCalculator
$remainingAvailability = $this->calculateRemainingAvailability($bookingDto, $participantIndex);
return array_filter($services, function (Service $service) use ($remainingAvailability) {
// If service has no availability limit set, treat as unlimited
if (null === $service->available || $service->available <= 0) {
// If service has no availability limit set (null), treat as unlimited
if (null === $service->available) {
return true;
}
// For services with availability limits, check remaining availability
// If availability is 0, service is sold out at the API level
if (0 === $service->available) {
return false;
}
// For services with positive availability, check remaining availability
return ($remainingAvailability[$service->id] ?? $service->available) > 0;
});
}
@@ -94,11 +99,22 @@ class ServiceAvailabilityCalculator
}
}
// If service not found or has no availability limit, it's not unavailable
if (null === $service || null === $service->available || $service->available <= 0) {
// If service not found, treat as available (not unavailable)
if (null === $service) {
return false;
}
// If no availability tracking (null), service is unlimited and available
if (null === $service->available) {
return false;
}
// If availability is 0, service is sold out at the API level
if (0 === $service->available) {
return true;
}
// For services with positive availability, calculate remaining based on booking selections
$remainingAvailability = $this->calculateRemainingAvailability($bookingDto, $participantIndex);
return ($remainingAvailability[$serviceId] ?? $service->available) <= 0;
@@ -195,7 +211,7 @@ class ServiceAvailabilityCalculator
{
$allServices = [];
// Get transportation services
// Get all transportation services
$transportationServices = array_merge(
$bookingDto->travel->getTransportationServicesByDirection(DirectionMapper::OUTBOUND_TRAVEL) ?? [],
$bookingDto->travel->getTransportationServicesByDirection(DirectionMapper::INBOUND_TRAVEL) ?? []