feat: cap rooms sharing a contingent per booking

This commit is contained in:
fromme committed 2026-11-11 16:35:49 +01:00
1 parent 5942ecf340
commit 3d94505e8d
18 files changed
+671 -19

No files matched your search

@@ -0,0 +1,151 @@
<?php
declare(strict_types=1);
namespace App\Tests\Service;
use App\BpnConnect\RoomsClient;
use App\BusProNet\Constants;
use App\BusProNet\Model\Room;
use App\BusProNet\Model\Travel;
use App\Service\RoomContingentPoolResolver;
use PHPUnit\Framework\TestCase;
use Psr\Log\NullLogger;
use Symfony\Component\Cache\Adapter\ArrayAdapter;
use Symfony\Component\HttpClient\MockHttpClient;
use Symfony\Component\HttpClient\Response\MockResponse;
class RoomContingentPoolResolverTest extends TestCase
{
private const array POOLS_163113 = [
['room_type_id' => 27, 'pool_room_type_id' => 27],
['room_type_id' => 2366, 'pool_room_type_id' => 2366],
['room_type_id' => 2367, 'pool_room_type_id' => 2366],
['room_type_id' => 2368, 'pool_room_type_id' => 2366],
];
public function testGroupsOfferedRoomsThatShareAContingent(): void
{
$resolver = $this->resolver(new MockHttpClient($this->poolsResponse(self::POOLS_163113)));
$pools = $resolver->findSharedPools($this->createTravel([
$this->createRoom(27, 'Doppelzimmer', available: 3),
$this->createRoom(2366, '8er App mit 8 Personen', available: 1),
$this->createRoom(2367, '8er App mit 7 Personen', available: 1),
$this->createRoom(2368, '8er App mit 6 Personen', available: 1),
]));
self::assertCount(1, $pools);
self::assertSame([2366, 2367, 2368], array_keys($pools[0]->rooms));
self::assertSame(1, $pools[0]->getAvailable());
}
public function testLeavesOutPoolsWithASingleOfferedRoom(): void
{
$resolver = $this->resolver(new MockHttpClient($this->poolsResponse(self::POOLS_163113)));
$pools = $resolver->findSharedPools($this->createTravel([
$this->createRoom(2366, '8er App mit 8 Personen', available: 1),
$this->createRoom(2367, '8er App mit 7 Personen', available: 0),
]));
self::assertSame([], $pools);
}
public function testAsksBpnConnectOncePerHotel(): void
{
$calls = 0;
$http = new MockHttpClient(function () use (&$calls): MockResponse {
++$calls;
return $this->poolsResponse(self::POOLS_163113);
});
$resolver = $this->resolver($http);
$travel = $this->sharedPoolTravel();
$resolver->findSharedPools($travel);
$resolver->findSharedPools($travel);
self::assertSame(1, $calls);
}
public function testTreatsEveryRoomAsItsOwnPoolWhenBpnConnectFailsAndAsksAgainNextTime(): void
{
$calls = 0;
$http = new MockHttpClient(function () use (&$calls): MockResponse {
++$calls;
return 1 === $calls
? new MockResponse('', ['http_code' => 503])
: $this->poolsResponse(self::POOLS_163113);
});
$resolver = $this->resolver($http);
$travel = $this->sharedPoolTravel();
self::assertSame([], $resolver->findSharedPools($travel));
self::assertCount(1, $resolver->findSharedPools($travel));
self::assertSame(2, $calls);
}
public function testATravelWithoutHotelHasNoPools(): void
{
$http = new MockHttpClient(function (): MockResponse {
self::fail('bpn-connect must not be asked without a hotel');
});
$travel = $this->sharedPoolTravel();
$travel->hotelId = null;
self::assertSame([], $this->resolver($http)->findSharedPools($travel));
}
private function sharedPoolTravel(): Travel
{
return $this->createTravel([
$this->createRoom(2366, '8er App mit 8 Personen', available: 1),
$this->createRoom(2367, '8er App mit 7 Personen', available: 1),
]);
}
/**
* @param list<array{room_type_id: int, pool_room_type_id: int}> $data
*/
private function poolsResponse(array $data): MockResponse
{
return new MockResponse(json_encode(['meta' => ['hotel_id' => 163113], 'data' => $data], JSON_THROW_ON_ERROR), [
'response_headers' => ['content-type' => 'application/json'],
]);
}
private function resolver(MockHttpClient $http): RoomContingentPoolResolver
{
return new RoomContingentPoolResolver(
new RoomsClient($http, new NullLogger(), 'https://bpn-connect.test', 'secret'),
new ArrayAdapter(),
new NullLogger(),
);
}
/**
* @param list<Room> $rooms
*/
private function createTravel(array $rooms): Travel
{
$travel = new Travel();
$travel->hotelId = 163113;
$travel->rooms = $rooms;
return $travel;
}
private function createRoom(int $id, string $label, int $available): Room
{
$room = new Room();
$room->id = $id;
$room->label = $label;
$room->available = $available;
$room->status = Constants::STATUS_AVAILABLE;
return $room;
}
}