chore: major code cleanup and type safety using phpstan

src/BusProNet/Constants.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet;
 

src/BusProNet/DataProcessor/BookingDataProcessor.php

@@ -128,7 +128,7 @@ class BookingDataProcessor
 
             // Parking service (for self-organized PKW transportation)
             $parkingServices = $booking->getAdditionalServicesForParticipantByGroup($index, Constants::TOKEN_PARKING);
-            if (false === empty($parkingServices)) {
+            if ([] !== $parkingServices) {
                 $participantData->parking = true;
                 $participantData->parkingService = reset($parkingServices);
             } else {
@@ -320,7 +320,7 @@ class BookingDataProcessor
 
         // Add purchase vouchers if any exist
         $purchaseVouchers = $this->mappingCollector->collectPurchaseVouchers($formData);
-        if (false === empty($purchaseVouchers)) {
+        if ([] !== $purchaseVouchers) {
             $payload['gutscheine']['gutschein'] = [];
             foreach ($purchaseVouchers as $code) {
                 $payload['gutscheine']['gutschein'][] = [

src/BusProNet/DataProcessor/ServiceMappingCollector.php

@@ -43,7 +43,7 @@ class ServiceMappingCollector
      * Groups board, ski passes, rentals, rental insurance, courses, parking, and additional services
      * by service ID with their participant assignments (1-based).
      *
-     * @return array<string, array<int>> Map of service ID to participant IDs
+     * @return array<int, list<int>> Map of service ID to participant IDs
      */
     public function collectServiceMappings(BookingDto $bookingDto): array
     {
@@ -99,7 +99,7 @@ class ServiceMappingCollector
     /**
      * Collects transportation service mappings.
      *
-     * @return array<string, array<int>> Map of transportation service ID to participant IDs
+     * @return array<int, list<int>> Map of transportation service ID to participant IDs
      */
     public function collectTransportationMappings(BookingDto $bookingDto): array
     {
@@ -126,7 +126,7 @@ class ServiceMappingCollector
      * Collects the unified pickup selection which applies to both directions.
      * The API receives this as outbound pickup data.
      *
-     * @return array<string, array<int>> Map of pickup ID to participant IDs
+     * @return array<int, list<int>> Map of pickup ID to participant IDs
      */
     public function collectPickupMappings(BookingDto $bookingDto): array
     {
@@ -148,7 +148,7 @@ class ServiceMappingCollector
      *
      * Collects the drop-off selection for the inbound/return direction.
      *
-     * @return array<string, array<int>> Map of drop-off ID to participant IDs
+     * @return array<int, list<int>> Map of drop-off ID to participant IDs
      */
     public function collectDropOffMappings(BookingDto $bookingDto): array
     {
@@ -171,7 +171,7 @@ class ServiceMappingCollector
      * CRITICAL: Insurance data is only included in CREATE flow, not in UPDATE flow.
      * IMPORTANT: Excludes synthetic "no insurance" option from BPN transmission.
      *
-     * @return array<string, array<int>> Map of insurance ID to participant IDs
+     * @return array<string, list<int>> Map of insurance ID to participant IDs
      */
     public function collectInsuranceMappings(BookingDto $bookingDto): array
     {

src/BusProNet/Exception/ApiClientException.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\Exception;
 

src/BusProNet/Exception/ResponseParserException.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\Exception;
 

src/BusProNet/Form/ChoiceLoader/CountryChoiceLoader.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\Form\ChoiceLoader;
 

src/BusProNet/Form/CountryType.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\Form;
 

src/BusProNet/Model/Insurance.php

@@ -182,8 +182,15 @@ class Insurance
         $urls = [];
 
         foreach ($this->containedInsurances as $containedInsurance) {
-            if (null !== $containedInsurance->{$urlProperty}) {
-                $urls[] = $containedInsurance->{$urlProperty};
+            $url = match ($urlProperty) {
+                'urlInfo' => $containedInsurance->urlInfo,
+                'urlProductInfo' => $containedInsurance->urlProductInfo,
+                'urlTerms' => $containedInsurance->urlTerms,
+                default => null,
+            };
+
+            if (null !== $url) {
+                $urls[] = $url;
             }
         }
 

src/BusProNet/Model/Product.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\Model;
 

src/BusProNet/Traits/XmlParserTrait.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\Traits;
 

src/BusProNet/Utility/DateCodeUtility.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\Utility;
 

src/BusProNet/Utility/DayTimeUtility.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\Utility;
 

src/BusProNet/XmlLoader/AbstractLoader.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\XmlLoader;
 

src/BusProNet/XmlParser/AvailabilitiesParser.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\XmlParser;
 

src/BusProNet/XmlParser/BookingUpdateParser.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\XmlParser;
 

src/BusProNet/XmlParser/BookingsParser.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\XmlParser;
 

src/BusProNet/XmlParser/CountriesParser.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\XmlParser;
 

src/BusProNet/XmlParser/MutableDataParser.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\XmlParser;
 

src/BusProNet/XmlParser/NotificationParser.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\XmlParser;
 

src/BusProNet/XmlParser/PersonalDataParser.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\XmlParser;
 

src/BusProNet/XmlParser/ProductsParser.php

@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 namespace App\BusProNet\XmlParser;
 
@@ -15,10 +16,11 @@ class ProductsParser extends AbstractParser
         $result
             ->filterXPath('//produkte/produkt')
             ->each(function (Crawler $node) use (&$products) {
-                if (false === empty($node->attr('code'))) {
+                $code = $node->attr('code');
+                if (null !== $code && '' !== $code) {
                     $product = new Product();
                     $product->id = (int) $node->attr('id');
-                    $product->code = (string) $node->attr('code');
+                    $product->code = $code;
                     $product->name = (string) $node->attr('bezeichnung');
 
                     $products[$product->id] = $product;