chore: major code cleanup and type safety using phpstan

tests/BusProNet/DataLoader/HotelDataLoaderTest.php

@@ -27,7 +27,7 @@ class HotelDataLoaderTest extends TestCase
 </hotels>';
 
         $filesystem = $this->createMock(FilesystemOperator::class);
-        $filesystem->expects($this->once())
+        $filesystem->expects(self::once())
             ->method('read')
             ->with('hotel.xml')
             ->willReturn($xmlContent);
@@ -37,17 +37,17 @@ class HotelDataLoaderTest extends TestCase
 
         $hotels = $loader->loadAll();
 
-        $this->assertIsArray($hotels);
-        $this->assertArrayHasKey(163113, $hotels);
+        self::assertIsArray($hotels);
+        self::assertArrayHasKey(163113, $hotels);
 
         $hotel = $hotels[163113];
-        $this->assertInstanceOf(Hotel::class, $hotel);
-        $this->assertEquals(163113, $hotel->id);
-        $this->assertEquals('L\'Oxalys', $hotel->name);
-        $this->assertEquals('SBWOXA', $hotel->code);
-        $this->assertEquals('Val Thorens', $hotel->city);
-        $this->assertEquals('F', $hotel->country);
-        $this->assertEquals('Rue des Lacs', $hotel->street);
-        $this->assertEquals('', $hotel->phone);
+        self::assertInstanceOf(Hotel::class, $hotel);
+        self::assertEquals(163113, $hotel->id);
+        self::assertEquals('L\'Oxalys', $hotel->name);
+        self::assertEquals('SBWOXA', $hotel->code);
+        self::assertEquals('Val Thorens', $hotel->city);
+        self::assertEquals('F', $hotel->country);
+        self::assertEquals('Rue des Lacs', $hotel->street);
+        self::assertEquals('', $hotel->phone);
     }
 }

tests/BusProNet/DataLoader/PickupDataLoaderTest.php

@@ -27,7 +27,7 @@ class PickupDataLoaderTest extends TestCase
 </zustiege>';
 
         $filesystem = $this->createMock(FilesystemOperator::class);
-        $filesystem->expects($this->once())
+        $filesystem->expects(self::once())
             ->method('read')
             ->with('zustiege.xml')
             ->willReturn($xmlContent);
@@ -37,11 +37,11 @@ class PickupDataLoaderTest extends TestCase
 
         $pickup = $loader->loadById(1);
 
-        $this->assertInstanceOf(Pickup::class, $pickup);
-        $this->assertEquals(1, $pickup->id);
-        $this->assertEquals('MS-Hbf', $pickup->code);
-        $this->assertEquals('Münster', $pickup->city);
-        $this->assertEquals('48143', $pickup->postalCode);
-        $this->assertEquals('Hafenstr/Ecke Friedrich-Ebert-Str', $pickup->street);
+        self::assertInstanceOf(Pickup::class, $pickup);
+        self::assertEquals(1, $pickup->id);
+        self::assertEquals('MS-Hbf', $pickup->code);
+        self::assertEquals('Münster', $pickup->city);
+        self::assertEquals('48143', $pickup->postalCode);
+        self::assertEquals('Hafenstr/Ecke Friedrich-Ebert-Str', $pickup->street);
     }
 }

tests/BusProNet/DataLoader/TravelDataLoaderTest.php

@@ -29,7 +29,7 @@ class TravelDataLoaderTest extends TestCase
 </reisen>';
 
         $filesystem = $this->createMock(FilesystemOperator::class);
-        $filesystem->expects($this->once())
+        $filesystem->expects(self::once())
             ->method('read')
             ->with('test_file.xml')
             ->willReturn($xmlContent);
@@ -45,7 +45,7 @@ class TravelDataLoaderTest extends TestCase
         $expectedTravel->label = 'Davos - Sportclub Waldschlössli';
         $expectedTravel->priceFrom = 534.2;
 
-        $travelParser->expects($this->once())
+        $travelParser->expects(self::once())
             ->method('parse')
             ->willReturn($expectedTravel);
 
@@ -54,12 +54,12 @@ class TravelDataLoaderTest extends TestCase
 
         $travel = $loader->loadById(11478, null, 'test_file.xml');
 
-        $this->assertInstanceOf(Travel::class, $travel);
-        $this->assertEquals('DPWMP060125', $travel->code);
-        $this->assertEquals('F', $travel->type);
-        $this->assertInstanceOf(\DateTimeImmutable::class, $travel->dateFrom);
-        $this->assertInstanceOf(\DateTimeImmutable::class, $travel->dateTo);
-        $this->assertEquals('Davos - Sportclub Waldschlössli', $travel->label);
-        $this->assertEquals(534.2, $travel->priceFrom);
+        self::assertInstanceOf(Travel::class, $travel);
+        self::assertEquals('DPWMP060125', $travel->code);
+        self::assertEquals('F', $travel->type);
+        self::assertInstanceOf(\DateTimeImmutable::class, $travel->dateFrom);
+        self::assertInstanceOf(\DateTimeImmutable::class, $travel->dateTo);
+        self::assertEquals('Davos - Sportclub Waldschlössli', $travel->label);
+        self::assertEquals(534.2, $travel->priceFrom);
     }
 }