chore: major code cleanup and type safety using phpstan
This commit is contained in:
1 parent
060cbea9da
commit
3da73d626b
103 files changed
+976
-1192
No files matched your search
@@ -26,8 +26,8 @@ class AcceptedVouchersTest extends TestCase
|
||||
amount: 100.00
|
||||
));
|
||||
|
||||
$this->assertEquals(150.0, $acceptedVouchers->getTotalDiscount());
|
||||
$this->assertCount(2, $acceptedVouchers->getVouchers());
|
||||
self::assertEquals(150.0, $acceptedVouchers->getTotalDiscount());
|
||||
self::assertCount(2, $acceptedVouchers->getVouchers());
|
||||
}
|
||||
|
||||
public function testFilterVouchersByType(): void
|
||||
@@ -52,17 +52,17 @@ class AcceptedVouchersTest extends TestCase
|
||||
amount: 75.00
|
||||
));
|
||||
|
||||
$this->assertCount(1, $acceptedVouchers->getPromotionalVouchers());
|
||||
$this->assertCount(1, $acceptedVouchers->getPurchaseVouchers());
|
||||
$this->assertCount(1, $acceptedVouchers->getGoodwillVouchers());
|
||||
self::assertCount(1, $acceptedVouchers->getPromotionalVouchers());
|
||||
self::assertCount(1, $acceptedVouchers->getPurchaseVouchers());
|
||||
self::assertCount(1, $acceptedVouchers->getGoodwillVouchers());
|
||||
}
|
||||
|
||||
public function testHasVouchersReturnsFalseWhenEmpty(): void
|
||||
{
|
||||
$acceptedVouchers = new AcceptedVouchersDto();
|
||||
|
||||
$this->assertFalse($acceptedVouchers->hasVouchers());
|
||||
$this->assertEquals(0, $acceptedVouchers->count());
|
||||
self::assertFalse($acceptedVouchers->hasVouchers());
|
||||
self::assertEquals(0, $acceptedVouchers->count());
|
||||
}
|
||||
|
||||
public function testHasVouchersReturnsTrueWhenNotEmpty(): void
|
||||
@@ -75,8 +75,8 @@ class AcceptedVouchersTest extends TestCase
|
||||
amount: 50.00
|
||||
));
|
||||
|
||||
$this->assertTrue($acceptedVouchers->hasVouchers());
|
||||
$this->assertEquals(1, $acceptedVouchers->count());
|
||||
self::assertTrue($acceptedVouchers->hasVouchers());
|
||||
self::assertEquals(1, $acceptedVouchers->count());
|
||||
}
|
||||
|
||||
public function testFloatPrecisionHandling(): void
|
||||
@@ -102,6 +102,6 @@ class AcceptedVouchersTest extends TestCase
|
||||
));
|
||||
|
||||
// Should be exactly 100.00 with proper rounding
|
||||
$this->assertEquals(100.0, $acceptedVouchers->getTotalDiscount());
|
||||
self::assertEquals(100.0, $acceptedVouchers->getTotalDiscount());
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user