From 490acc2e8bc8e7a992cfcab911816b6742ca71af Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Fromme?= <fromme@dreipunktnull.com>
Date: Wed, 12 Aug 2026 17:41:38 +0200
Subject: [PATCH] chore: correct stale role_hierarchy comments

---
 src/Controller/Admin/AccommodationBooking/EditController.php   | 3 ++-
 src/Controller/Admin/AccommodationBooking/FilterController.php | 3 ++-
 src/Controller/Admin/AccommodationBooking/IndexController.php  | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/Controller/Admin/AccommodationBooking/EditController.php b/src/Controller/Admin/AccommodationBooking/EditController.php
index cdbd247..5616919 100644
--- a/src/Controller/Admin/AccommodationBooking/EditController.php
+++ b/src/Controller/Admin/AccommodationBooking/EditController.php
@@ -71,7 +71,8 @@ class EditController extends AbstractController
             ));
         }
 
-        // ROLE_ADMIN inherits ROLE_GROUPS_ADMIN, so this single check covers both.
+        // ROLE_GROUPS_ADMIN is granted explicitly since 6c1073e4 removed it from ROLE_ADMIN's
+        // role_hierarchy — an administrator who needs this has to hold it in their own right.
         $assignableManagers = [];
         if ($this->isGranted('ROLE_GROUPS_ADMIN')) {
             $assignableManagers = $this->userRepo->findGroupsStaff();
diff --git a/src/Controller/Admin/AccommodationBooking/FilterController.php b/src/Controller/Admin/AccommodationBooking/FilterController.php
index 0395158..b3b71fc 100644
--- a/src/Controller/Admin/AccommodationBooking/FilterController.php
+++ b/src/Controller/Admin/AccommodationBooking/FilterController.php
@@ -34,7 +34,8 @@ class FilterController extends AbstractController
     #[Route('/admin/accommodation-booking/filter', name: 'app_admin_accommodationbooking_filter', methods: ['GET'])]
     public function filter(Request $request): Response
     {
-        // ROLE_ADMIN inherits ROLE_GROUPS_ADMIN, so this single check covers both.
+        // ROLE_GROUPS_ADMIN is granted explicitly since 6c1073e4 removed it from ROLE_ADMIN's
+        // role_hierarchy — an administrator who needs this has to hold it in their own right.
         $seesAllBookings = $this->isGranted('ROLE_GROUPS_ADMIN');
         $user = $this->getUser();
 
diff --git a/src/Controller/Admin/AccommodationBooking/IndexController.php b/src/Controller/Admin/AccommodationBooking/IndexController.php
index 1b04ac0..b9ad84a 100644
--- a/src/Controller/Admin/AccommodationBooking/IndexController.php
+++ b/src/Controller/Admin/AccommodationBooking/IndexController.php
@@ -32,7 +32,8 @@ class IndexController extends AbstractController
     #[Route('/admin/accommodation-booking', name: 'app_admin_accommodationbooking')]
     public function index(Request $request): Response
     {
-        // ROLE_ADMIN inherits ROLE_GROUPS_ADMIN, so this single check covers both.
+        // ROLE_GROUPS_ADMIN is granted explicitly since 6c1073e4 removed it from ROLE_ADMIN's
+        // role_hierarchy — an administrator who needs this has to hold it in their own right.
         $seesAllBookings = $this->isGranted('ROLE_GROUPS_ADMIN');
         $user = $this->getUser();
         $user = $user instanceof User ? $user : null;