fix: refuse implausible accommodation booking prices
This commit is contained in:
1 parent
773cd4f847
commit
56adf72d12
16 files changed
+628
-15
No files matched your search
@@ -8,6 +8,7 @@ use App\Controller\Admin\AccommodationBooking\ChangeAccommodationController;
|
||||
use App\Entity\Groups\Accommodation;
|
||||
use App\Entity\Groups\AccommodationBooking;
|
||||
use App\Enum\Groups\AccommodationBookingStatus;
|
||||
use App\Exception\ImplausibleBookingPriceException;
|
||||
use App\Service\AccommodationBookingService;
|
||||
use PHPUnit\Framework\Attributes\DataProvider;
|
||||
use PHPUnit\Framework\TestCase;
|
||||
@@ -87,6 +88,36 @@ class ChangeAccommodationControllerTest extends TestCase
|
||||
self::assertSame('success', $controller->flashes[0]['type']);
|
||||
}
|
||||
|
||||
public function testAHouseThatPricesImplausiblyIsReportedInTheModal(): void
|
||||
{
|
||||
// The service leaves the booking at its old house and rethrows; the office has to see why
|
||||
// the change did not happen, on the modal it just submitted, not as an error page.
|
||||
$booking = $this->draft();
|
||||
|
||||
$bookingService = $this->createStub(AccommodationBookingService::class);
|
||||
$bookingService->method('changeAccommodation')
|
||||
->willThrowException(new ImplausibleBookingPriceException(AccommodationBooking::MAX_TOTAL_PRICE + 1, 40, 2));
|
||||
|
||||
$field = $this->createStub(FormInterface::class);
|
||||
$field->method('getData')->willReturn(new Accommodation());
|
||||
|
||||
$form = $this->createMock(FormInterface::class);
|
||||
$form->method('handleRequest')->willReturn($form);
|
||||
$form->method('isSubmitted')->willReturn(true);
|
||||
$form->method('isValid')->willReturn(true);
|
||||
$form->method('get')->with('accommodation')->willReturn($field);
|
||||
$form->expects(self::once())->method('addError');
|
||||
|
||||
$controller = $this->buildController($bookingService, $form);
|
||||
|
||||
$response = $controller->index($booking, $this->request('POST'));
|
||||
|
||||
self::assertSame(Response::HTTP_OK, $response->getStatusCode());
|
||||
self::assertFalse($response->headers->has('HX-Redirect'), 'the modal stays open on the error');
|
||||
self::assertSame('admin/accommodation_booking/modal_change_accommodation.html.twig', $controller->renderedView);
|
||||
self::assertSame([], $controller->flashes, 'nothing was changed, so nothing is reported as success');
|
||||
}
|
||||
|
||||
public function testPickingTheSameHouseIsNotReportedAsAChange(): void
|
||||
{
|
||||
$booking = $this->draft();
|
||||
|
||||
Reference in new issue
Block a user