From 677ffc7368d88c32319ffef6e0820949bf1bb04e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Fromme?= <fromme@dreipunktnull.com>
Date: Wed, 28 Jan 2026 19:40:48 +0100
Subject: [PATCH] fix: streamline datalayer integration for all events

---
 assets/controllers/data_layer_controller.js | 11 ++------
 templates/_partials/_tracking.html.twig     |  9 ++++---
 templates/booking/create/success.html.twig  | 28 +++++++++------------
 3 files changed, 20 insertions(+), 28 deletions(-)

diff --git a/assets/controllers/data_layer_controller.js b/assets/controllers/data_layer_controller.js
index ace8d81..ce78da2 100644
--- a/assets/controllers/data_layer_controller.js
+++ b/assets/controllers/data_layer_controller.js
@@ -2,19 +2,12 @@ import { Controller } from '@hotwired/stimulus';
 
 export default class extends Controller {
     static values = {
-        url: String,
-        title: String,
-        userInfo: String
+        payload: Object
     };
 
     connect() {
         if (typeof window.dataLayer !== 'undefined') {
-            window.dataLayer.push({
-                'event': 'VirtualPageview',
-                'virtualPageURL': this.urlValue,
-                'virtualPageTitle': this.titleValue,
-                'userInfo': this.userInfoValue
-            });
+            window.dataLayer.push(this.payloadValue);
         }
     }
 }
diff --git a/templates/_partials/_tracking.html.twig b/templates/_partials/_tracking.html.twig
index 91c987b..4d4987c 100644
--- a/templates/_partials/_tracking.html.twig
+++ b/templates/_partials/_tracking.html.twig
@@ -1,5 +1,8 @@
 <div {{ stimulus_controller('data-layer', {
-    'url': url,
-    'title': title,
-    'userInfo': is_granted('ROLE_USER') ? 'mitglied' : 'gast'
+    'payload': {
+        'event': 'VirtualPageview',
+        'virtualPageURL': url,
+        'virtualPageTitle': title,
+        'userInfo': is_granted('ROLE_USER') ? 'mitglied' : 'gast'
+    }
 }) }}></div>
diff --git a/templates/booking/create/success.html.twig b/templates/booking/create/success.html.twig
index 4836af3..1bdfb4e 100644
--- a/templates/booking/create/success.html.twig
+++ b/templates/booking/create/success.html.twig
@@ -59,22 +59,18 @@
 
 {% block data_layer %}
     {% if bookingTotal is not null and travelName is not null %}
-        <script>
-            window.dataLayer = window.dataLayer || [];
-            var consent = (window.CookieFirst && window.CookieFirst.consent) || { advertising: false };
-            if (consent.advertising) {
-                dataLayer.push({
-                    'event': 'Transaction',
-                    'userInfo': '{{ is_granted('ROLE_USER') ? 'mitglied' : 'gast' }}',
-                    'transactionId': '{{ bookingNumber }}',
-                    'transactionTotal': {{ bookingTotal }},
-                    'transactionProducts': [{
-                        'name': '{{ travelName|e('js') }}',
-                        'price': {{ bookingTotal }},
-                        'quantity': 1
-                    }]
-                });
+        <div {{ stimulus_controller('data-layer', {
+            'payload': {
+                'event': 'Transaction',
+                'userInfo': is_granted('ROLE_USER') ? 'mitglied' : 'gast',
+                'transactionId': bookingNumber,
+                'transactionTotal': bookingTotal,
+                'transactionProducts': [{
+                    'name': travelName,
+                    'price': bookingTotal,
+                    'quantity': 1
+                }]
             }
-        </script>
+        }) }}></div>
     {% endif %}
 {% endblock %}