feat: hide unavailable ski passes from selection in create flow

2026-08-06 13:08:46 +02:00
parent b82e017f73
commit 6ee00f2bee
6 changed files with 329 additions and 30 deletions
@@ -29,6 +29,12 @@ class ParticipantFieldOptionsProviderBabyTest extends TestCase
    protected function setUp(): void
    {
        $this->serviceAvailabilityCalculator = $this->createMock(ServiceAvailabilityCalculator::class);
+        // These tests target age filtering, so availability filtering passes everything through
+        // unless a test stubs it explicitly
+        $this->serviceAvailabilityCalculator
+            ->method('filterAvailableServices')
+            ->willReturnArgument(0)
+        ;
        $insuranceService = $this->createMock(InsuranceManager::class);
        $priceCalculatorService = $this->createMock(BookingPriceCalculator::class);
        $serviceLabelFormatter = new ServiceLabelFormatter();
@@ -0,0 +1,185 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Tests\Form\Service;
+
+use App\BusProNet\Constants;
+use App\BusProNet\Model\Booking;
+use App\BusProNet\Model\Service;
+use App\BusProNet\Model\Travel;
+use App\Form\Model\BookingDto;
+use App\Form\Model\ParticipantDto;
+use App\Form\Service\ParticipantFieldOptionsProvider;
+use App\Service\BookingPriceCalculator;
+use App\Service\InsuranceManager;
+use App\Service\ServiceAvailabilityCalculator;
+use App\Service\ServiceLabelFormatter;
+use PHPUnit\Framework\TestCase;
+use Symfony\Contracts\Translation\TranslatorInterface;
+
+/**
+ * Unavailable ski passes are removed from the choices instead of being rendered read-only.
+ *
+ * Uses a real ServiceAvailabilityCalculator so the filtering and the availability rules are
+ * covered together.
+ */
+class ParticipantFieldOptionsProviderSkiPassAvailabilityTest extends TestCase
+{
+    private ParticipantFieldOptionsProvider $provider;
+
+    protected function setUp(): void
+    {
+        $translator = $this->createMock(TranslatorInterface::class);
+        $translator->method('trans')->willReturnArgument(0);
+
+        $this->provider = new ParticipantFieldOptionsProvider(
+            new ServiceAvailabilityCalculator(),
+            $this->createMock(InsuranceManager::class),
+            $this->createMock(BookingPriceCalculator::class),
+            new ServiceLabelFormatter(),
+            $translator
+        );
+    }
+
+    public function testSoldOutSkiPassIsNotRendered(): void
+    {
+        $bookingDto = $this->createBookingDto([
+            $this->createSkiPass(id: 1, available: null),
+            $this->createSkiPass(id: 2, available: 0),
+        ]);
+
+        $this->assertSame([1], $this->getSkiPassChoiceIds($bookingDto));
+    }
+
+    public function testSkiPassOnBookingStopIsNotRendered(): void
+    {
+        $bookingDto = $this->createBookingDto([
+            $this->createSkiPass(id: 1, available: null),
+            $this->createSkiPass(id: 2, available: 20, status: Constants::STATUS_BLOCKED),
+        ]);
+
+        $this->assertSame([1], $this->getSkiPassChoiceIds($bookingDto));
+    }
+
+    public function testSkiPassClaimedByOtherParticipantIsNotRendered(): void
+    {
+        $limitedSkiPass = $this->createSkiPass(id: 2, available: 1);
+        $bookingDto = $this->createBookingDto([
+            $this->createSkiPass(id: 1, available: null),
+            $limitedSkiPass,
+        ]);
+
+        $otherParticipant = new ParticipantDto();
+        $otherParticipant->index = 1;
+        $otherParticipant->dateOfBirth = new \DateTimeImmutable('1990-01-01');
+        $otherParticipant->skiPass = $limitedSkiPass;
+        $bookingDto->participants[1] = $otherParticipant;
+
+        $this->assertSame([1], $this->getSkiPassChoiceIds($bookingDto));
+    }
+
+    public function testSelectedSkiPassStaysRenderedWhenItSoldOut(): void
+    {
+        $soldOutSkiPass = $this->createSkiPass(id: 2, available: 0);
+        $bookingDto = $this->createBookingDto([
+            $this->createSkiPass(id: 1, available: null),
+            $soldOutSkiPass,
+        ]);
+
+        $bookingDto->participants[0]->skiPass = $soldOutSkiPass;
+
+        $this->assertSame([1, 2], $this->getSkiPassChoiceIds($bookingDto));
+    }
+
+    public function testBookedSkiPassStaysRenderedAfterSwitchingToAnotherPassInEditMode(): void
+    {
+        $blockedSkiPass = $this->createSkiPass(id: 2, available: null, status: Constants::STATUS_BLOCKED);
+        $bookableSkiPass = $this->createSkiPass(id: 1, available: null);
+        $bookingDto = $this->createBookingDto([$bookableSkiPass, $blockedSkiPass]);
+
+        $bookedSkiPass = clone $blockedSkiPass;
+        $bookedSkiPass->mapping = [0];
+
+        $booking = new Booking();
+        $booking->additionalServices = [2 => $bookedSkiPass];
+        $bookingDto->booking = $booking;
+
+        // The participant already moved away from the booked pass - it still has to be offered
+        // so the switch stays reversible
+        $bookingDto->participants[0]->skiPass = $bookableSkiPass;
+
+        $this->assertSame(BookingDto::MODE_EDIT, $bookingDto->getMode());
+        $this->assertSame([1, 2], $this->getSkiPassChoiceIds($bookingDto));
+    }
+
+    public function testRenderedSkiPassesCarryNoSoldOutTooltip(): void
+    {
+        $soldOutSkiPass = $this->createSkiPass(id: 2, available: 0);
+        $bookingDto = $this->createBookingDto([
+            $this->createSkiPass(id: 1, available: null),
+            $soldOutSkiPass,
+        ]);
+
+        $bookingDto->participants[0]->skiPass = $soldOutSkiPass;
+
+        $options = $this->provider->getFieldOptions('skiPass', $bookingDto, 0);
+        $choiceAttr = $options['choice_attr'];
+
+        foreach ($options['choices'] as $choice) {
+            $attributes = $choiceAttr($choice);
+
+            $this->assertArrayNotHasKey('readonly', $attributes);
+            $this->assertArrayNotHasKey('data-tooltip', $attributes);
+        }
+    }
+
+    /** @return int[] */
+    private function getSkiPassChoiceIds(BookingDto $bookingDto): array
+    {
+        $options = $this->provider->getFieldOptions('skiPass', $bookingDto, 0);
+
+        if (true === empty($options)) {
+            return [];
+        }
+
+        $choiceIds = array_map(static fn (Service $service): ?int => $service->id, $options['choices']);
+        sort($choiceIds);
+
+        return $choiceIds;
+    }
+
+    /** @param Service[] $skiPasses */
+    private function createBookingDto(array $skiPasses): BookingDto
+    {
+        $travel = new Travel();
+        $travel->dateFrom = new \DateTimeImmutable('2027-01-09');
+        $travel->dateTo = new \DateTimeImmutable('2027-01-16');
+
+        foreach ($skiPasses as $skiPass) {
+            $travel->additionalServices[$skiPass->id] = $skiPass;
+        }
+
+        $bookingDto = new BookingDto($travel, 1);
+
+        $participant = new ParticipantDto();
+        $participant->index = 0;
+        $participant->dateOfBirth = new \DateTimeImmutable('1990-01-01');
+        $bookingDto->participants[0] = $participant;
+
+        return $bookingDto;
+    }
+
+    private function createSkiPass(int $id, ?int $available, string $status = Constants::STATUS_AVAILABLE): Service
+    {
+        $service = new Service();
+        $service->id = $id;
+        $service->label = sprintf('Skipass %d', $id);
+        $service->subType = Constants::TOKEN_SKI_PASS;
+        $service->price = (float) $id;
+        $service->available = $available;
+        $service->status = $status;
+
+        return $service;
+    }
+}