EP/myep
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: assignable managers for accommodation bookings

Browse Source
This commit is contained in:
Björn Fromme
2026-08-05 13:45:33 +02:00
parent 8e4afc0813
commit 736128476b
9 changed files with 247 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Controller/Admin/AccommodationBooking/EditControllerTest.php
+84 -1
View File
@@ -7,8 +7,10 @@ namespace App\Tests\Controller\Admin\AccommodationBooking;
use App\Controller\Admin\AccommodationBooking\EditController;
use App\Entity\Groups\AccommodationBooking;
use App\Enum\Groups\AccommodationBookingStatus;
use App\Entity\User;
use App\Repository\Groups\AdditionalServiceRepository;
use App\Repository\Groups\BoardServiceRepository;
use App\Repository\UserRepository;
use App\Service\AccommodationBookingService;
use Doctrine\ORM\EntityManagerInterface;
use PHPUnit\Framework\TestCase;
@@ -101,6 +103,7 @@ class EditControllerTest extends TestCase
$this->createMock(LoggerInterface::class),
$this->createMock(BoardServiceRepository::class),
$this->createMock(AdditionalServiceRepository::class),
$this->createMock(UserRepository::class),
$bookingService,
$form,
);
@@ -109,26 +112,106 @@ class EditControllerTest extends TestCase
self::assertSame(Response::HTTP_FOUND, $response->getStatusCode());
}
public function testManagerWithoutAdminRoleGetsNoBetreuerChoices(): void
{
$userRepo = $this->createMock(UserRepository::class);
$userRepo->expects(self::never())->method('findGroupsStaff');
$controller = $this->buildController($userRepo, granted: false);
$controller->index(new AccommodationBooking(), Request::create('/admin/accommodation-booking/1/edit'));
self::assertSame([], $controller->capturedOptions['assignable_managers']);
}
public function testAdminGetsTheGroupsStaffAsBetreuerChoices(): void
{
$staff = [new User('[email protected]')];
$userRepo = $this->createMock(UserRepository::class);
$userRepo->method('findGroupsStaff')->willReturn($staff);
$controller = $this->buildController($userRepo, granted: true);
$controller->index(new AccommodationBooking(), Request::create('/admin/accommodation-booking/1/edit'));
self::assertSame($staff, $controller->capturedOptions['assignable_managers']);
}
public function testAnAssignedUserWhoLostTheRoleStaysSelectable(): void
{
$formerManager = new User('[email protected]');
$staff = [new User('[email protected]')];
$userRepo = $this->createMock(UserRepository::class);
$userRepo->method('findGroupsStaff')->willReturn($staff);
$booking = new AccommodationBooking();
$booking->setManagedBy($formerManager);
$controller = $this->buildController($userRepo, granted: true);
$controller->index($booking, Request::create('/admin/accommodation-booking/1/edit'));
self::assertSame([$staff[0], $formerManager], $controller->capturedOptions['assignable_managers']);
}
private function buildController(UserRepository $userRepo, bool $granted): TestableEditController
{
// An unsubmitted form: index() falls through to render() and only the options
// handed to createForm() are of interest here.
$form = $this->createMock(FormInterface::class);
$form->method('handleRequest')->willReturn($form);
$form->method('isSubmitted')->willReturn(false);
return new TestableEditController(
$this->createMock(EntityManagerInterface::class),
$this->createMock(LoggerInterface::class),
$this->createMock(BoardServiceRepository::class),
$this->createMock(AdditionalServiceRepository::class),
$userRepo,
$this->createMock(AccommodationBookingService::class),
$form,
$granted,
);
}
}
final class TestableEditController extends EditController
{
/** @var array<string, mixed> */
public array $capturedOptions = [];
public function __construct(
EntityManagerInterface $entityManager,
LoggerInterface $logger,
BoardServiceRepository $boardServiceRepo,
AdditionalServiceRepository $additionalServiceRepo,
UserRepository $userRepo,
AccommodationBookingService $bookingService,
private readonly FormInterface $form,
private readonly bool $granted = false,
) {
parent::__construct($entityManager, $logger, $boardServiceRepo, $additionalServiceRepo, $bookingService);
parent::__construct($entityManager, $logger, $boardServiceRepo, $additionalServiceRepo, $userRepo, $bookingService);
}
protected function createForm(string $type, mixed $data = null, array $options = []): FormInterface
{
$this->capturedOptions = $options;
return $this->form;
}
protected function isGranted(mixed $attribute, mixed $subject = null): bool
{
return $this->granted;
}
/**
* @param array<string, mixed> $parameters
*/
protected function render(string $view, array $parameters = [], ?Response $response = null): Response
{
return new Response();
}
protected function addFlash(string $type, mixed $message): void
{
}