EP/myep
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove redundant insurance hydration, cache snapshots and files map

Browse Source
This commit is contained in:
Björn Fromme
2026-04-03 15:20:37 +02:00
parent ca873a99f4
commit 7eb1cbdabd
2 changed files with 18 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Service/TravelDataServiceTest.php
+6 -6
View File
@@ -313,7 +313,7 @@ class TravelDataServiceTest extends TestCase
$this->assertSame($travel, $result);
}
public function testGetTravelDataFromLocalHydratesInsurancePackagesFromLoaderAfterSnapshotLoad(): void
public function testGetTravelDataFromLocalReplacesSnapshotInsurancesWithLoaderData(): void
{
$dateId = 12345;
$hotelId = 67890;
@@ -335,7 +335,8 @@ class TravelDataServiceTest extends TestCase
$package->id = '20';
$package->package = true;
$package->containedInsuranceIds = ['10'];
$package->containedInsurances = [];
// InsuranceParser populates containedInsurances at parse time; loadAll() returns hydrated data.
$package->containedInsurances = [$individual];
$this->travelSnapshotService
->expects($this->once())
@@ -396,13 +397,11 @@ class TravelDataServiceTest extends TestCase
$this->assertSame($travel, $result);
}
public function testGetTravelDataFromLocalRehydratesInsurancePackagesFromXmlFallback(): void
public function testGetTravelDataFromLocalAttachesLoaderInsurancesFromXmlFallback(): void
{
$dateId = 12345;
$hotelId = 67890;
// InsuranceLoader supplies the canonical insurance list for local reads; the package's
// containedInsurances starts empty and is rebuilt after hydration.
$individual = new Insurance();
$individual->id = '10';
$individual->package = false;
@@ -411,7 +410,8 @@ class TravelDataServiceTest extends TestCase
$package->id = '20';
$package->package = true;
$package->containedInsuranceIds = ['10'];
$package->containedInsurances = [];
// InsuranceParser populates containedInsurances at parse time; loadAll() returns hydrated data.
$package->containedInsurances = [$individual];
$travel = new Travel();
$travel->id = $dateId;