chore: further cleanup and refactor

src/Controller/Booking/Create/Step4Controller.php

@@ -7,10 +7,11 @@ namespace App\Controller\Booking\Create;
 use App\BusProNet\ApiClient;
 use App\BusProNet\Exception\TimeoutException;
 use App\BusProNet\Model\Notification;
-use App\Controller\Booking\Traits\BookingCreateTrait;
-use App\Controller\Booking\Traits\BookingExceptionHandlerTrait;
 use App\Entity\User;
+use App\Exception\BookingSessionNotFoundException;
+use App\Exception\HotelNotInTravelException;
 use App\Exception\NewsletterProviderException;
+use App\Exception\TravelNotFoundException;
 use App\Form\BookingCreateStep4Type;
 use App\Form\Model\BookingDto;
 use App\Htmx\HxTrait;
@@ -20,7 +21,6 @@ use App\Service\BookingSessionManager;
 use App\Service\MailjetApiClient;
 use App\Service\NewsletterManager;
 use Psr\Log\LoggerInterface;
-use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\Form\FormInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
@@ -30,10 +30,8 @@ use Symfony\Contracts\Cache\CacheInterface;
 /**
  * Handles the fourth step of the booking creation process (confirmation).
  */
-class Step4Controller extends AbstractController
+class Step4Controller extends AbstractBookingCreateController
 {
-    use BookingCreateTrait;
-    use BookingExceptionHandlerTrait;
     use HxTrait;
 
     public function __construct(
@@ -54,14 +52,14 @@ class Step4Controller extends AbstractController
     #[Route('/bookings/create/confirmation', name: 'app_booking_create_step_4')]
     public function index(Request $request): Response
     {
-        $result = $this->getOrCreateBookingCreateDto($this->bookingSessionService, $request);
-        if ($result instanceof Response) {
-            return $result;
+        try {
+            $bookingCreateDto = $this->loadBookingCreateDto($this->bookingSessionService, $request);
+        } catch (BookingSessionNotFoundException|TravelNotFoundException|HotelNotInTravelException $exception) {
+            return $this->createBookingCreateFailureResponse($exception, false);
         }
-        $bookingCreateDto = $result;
 
         // Validate step access
-        if ($redirect = $this->validateStepAccess($bookingCreateDto, 4)) {
+        if (null !== $redirect = $this->validateStepAccess($bookingCreateDto, 4)) {
             return $redirect;
         }