fix: treat dates without price as unavailable

src/Controller/Groups/Step1Controller.php

@@ -13,6 +13,7 @@ use App\Htmx\HxTrait;
 use App\Model\AccommodationBookingContext;
 use App\Repository\Groups\AccommodationPriceRepository;
 use App\Service\AccommodationBookingService;
+use App\Service\AccommodationPriceCoverage;
 use App\Service\AccommodationSessionManager;
 use App\Service\CalendarGridBuilder;
 use App\Service\GroupsPriceCalculator;
@@ -38,6 +39,7 @@ class Step1Controller extends AbstractAccommodationController
         private readonly CacheInterface $cache,
         private readonly CalendarGridBuilder $calendarGridBuilder,
         private readonly GroupsPriceCalculator $priceCalculator,
+        private readonly AccommodationPriceCoverage $priceCoverage,
     ) {
     }
 
@@ -225,9 +227,12 @@ class Step1Controller extends AbstractAccommodationController
     }
 
     /**
-     * Fetches contingent + price data and returns a map of date → ['status', 'minNights'].
+     * Fetches contingent + price data and returns a map of date → ['status', 'minNights']
+     * covering every day of the requested range.
      *
-     * Returns an empty array on API failure; the template treats missing dates as blocked.
+     * A day is only available when the contingent allows it *and* an AccommodationPrice
+     * covers it. On API failure the contingent imposes no restriction and price coverage
+     * alone decides.
      *
      * @return array<string, array{status: string, minNights: int}>
      */
@@ -238,6 +243,7 @@ class Step1Controller extends AbstractAccommodationController
         string $dateFromStr,
         string $dateToStr,
     ): array {
+        $calendar = null;
         try {
             $cacheKey = sprintf('contingents_calendar_%s_%s_%s', $hotelCode, $dateFromStr, $dateToStr);
             $calendar = $this->cache->get(
@@ -249,23 +255,38 @@ class Step1Controller extends AbstractAccommodationController
                 },
             );
         } catch (BpnConnectException|\Psr\Cache\InvalidArgumentException) {
-            return [];
+            // Fall through with $calendar === null — price coverage still applies
+        }
+
+        $contingentStatus = [];
+        if (null !== $calendar) {
+            foreach ($calendar->data as $entry) {
+                $contingentStatus[(new \DateTimeImmutable($entry->date))->format('Y-m-d')] = $entry->status;
+            }
         }
 
         $prices = $this->priceRepository->findByHotelCodeAndDateRange($hotelCode, $dateFrom, $dateTo);
+        $covered = $this->priceCoverage->coveredDatesFor($prices, $dateFrom, $dateTo);
+
+        $start = $dateFrom->setTime(0, 0);
+        $end = $dateTo->setTime(0, 0);
 
         $availableDates = [];
-        foreach ($calendar->data as $entry) {
-            if (ContingentStatus::Ok === $entry->status) {
-                $availableDates[$entry->date] = true;
+        for ($day = $start; $day <= $end; $day = $day->modify('+1 day')) {
+            $date = $day->format('Y-m-d');
+            // Days the contingent API does not mention are unrestricted
+            $status = $contingentStatus[$date] ?? ContingentStatus::Ok;
+
+            if (ContingentStatus::Ok === $status && isset($covered[$date])) {
+                $availableDates[$date] = true;
             }
         }
 
         $enriched = [];
-        foreach ($calendar->data as $entry) {
-            $isAvailable = ContingentStatus::Ok === $entry->status;
-            $prevDate = (new \DateTimeImmutable($entry->date))->modify('-1 day')->format('Y-m-d');
-            $prevAvailable = isset($availableDates[$prevDate]);
+        for ($day = $start; $day <= $end; $day = $day->modify('+1 day')) {
+            $date = $day->format('Y-m-d');
+            $isAvailable = isset($availableDates[$date]);
+            $prevAvailable = isset($availableDates[$day->modify('-1 day')->format('Y-m-d')]);
 
             $status = match (true) {
                 $isAvailable && $prevAvailable => 'ok',
@@ -274,14 +295,13 @@ class Step1Controller extends AbstractAccommodationController
                 default => 'blocked',
             };
 
-            $day = (new \DateTimeImmutable($entry->date))->setTime(0, 0);
             $candidates = array_values(array_filter(
                 $prices,
-                fn(AccommodationPrice $p): bool => $p->getDateFrom() <= $day && $p->getDateTo() >= $day,
+                fn (AccommodationPrice $p): bool => $p->getDateFrom() <= $day && $p->getDateTo() >= $day,
             ));
             $winner = $this->priceTimelineBuilder->resolveWinner($candidates);
 
-            $enriched[$entry->date] = [
+            $enriched[$date] = [
                 'status' => $status,
                 'minNights' => $winner?->getMinNights() ?? 0,
             ];