feat: enable entering additional remarks in offer confirmation

tests/Form/Admin/Groups/AccommodationBookingCreateTypeTest.php

@@ -0,0 +1,109 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Tests\Form\Admin\Groups;
+
+use App\Entity\Groups\AccommodationBooking;
+use App\Enum\Groups\AccommodationBookingStatus;
+use App\Form\Admin\Groups\AccommodationBookingCreateType;
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\Form\FormInterface;
+use Symfony\Component\OptionsResolver\OptionsResolver;
+use Symfony\Component\Validator\Constraints\Email;
+use Symfony\Component\Validator\Constraints\EmailValidator;
+use Symfony\Component\Validator\ConstraintValidatorFactory;
+use Symfony\Component\Validator\Validation;
+
+class AccommodationBookingCreateTypeTest extends TestCase
+{
+    public function testDraftsAreValidatedWithoutTheOfferGroup(): void
+    {
+        self::assertSame(['Default'], $this->resolveValidationGroups(AccommodationBookingStatus::Draft));
+    }
+
+    public function testOffersAddTheOfferGroup(): void
+    {
+        self::assertSame(['Default', 'offer'], $this->resolveValidationGroups(AccommodationBookingStatus::Open));
+    }
+
+    public function testDraftCanBeCreatedWithoutAnEmail(): void
+    {
+        $booking = new AccommodationBooking();
+        $booking->setStatus(AccommodationBookingStatus::Draft);
+
+        $violations = $this->validate($booking, $this->resolveValidationGroups(AccommodationBookingStatus::Draft));
+
+        self::assertCount(0, $violations);
+    }
+
+    public function testOfferCannotBeCreatedWithoutAnEmail(): void
+    {
+        $booking = new AccommodationBooking();
+        $booking->setStatus(AccommodationBookingStatus::Open);
+
+        $violations = $this->validate($booking, $this->resolveValidationGroups(AccommodationBookingStatus::Open));
+
+        $properties = array_map(static fn ($violation) => $violation->getPropertyPath(), iterator_to_array($violations));
+
+        self::assertSame(['email'], $properties, 'only the address is enforced here — the rest of the contact data belongs to the edit form');
+    }
+
+    public function testOfferRejectsAMalformedEmail(): void
+    {
+        $booking = new AccommodationBooking();
+        $booking->setStatus(AccommodationBookingStatus::Open);
+        $booking->setEmail('not-an-address');
+
+        $violations = $this->validate($booking, $this->resolveValidationGroups(AccommodationBookingStatus::Open));
+
+        self::assertCount(1, $violations);
+        self::assertSame('email', $violations[0]->getPropertyPath());
+    }
+
+    public function testOfferWithAnEmailIsValid(): void
+    {
+        $booking = new AccommodationBooking();
+        $booking->setStatus(AccommodationBookingStatus::Open);
+        $booking->setEmail('[email protected]');
+
+        $violations = $this->validate($booking, $this->resolveValidationGroups(AccommodationBookingStatus::Open));
+
+        self::assertCount(0, $violations);
+    }
+
+    /**
+     * @return string[]
+     */
+    private function resolveValidationGroups(AccommodationBookingStatus $status): array
+    {
+        $resolver = new OptionsResolver();
+        (new AccommodationBookingCreateType())->configureOptions($resolver);
+
+        $booking = new AccommodationBooking();
+        $booking->setStatus($status);
+
+        $form = $this->createMock(FormInterface::class);
+        $form->method('getData')->willReturn($booking);
+
+        return ($resolver->resolve()['validation_groups'])($form);
+    }
+
+    /**
+     * @param string[] $groups
+     */
+    private function validate(AccommodationBooking $booking, array $groups): \Symfony\Component\Validator\ConstraintViolationListInterface
+    {
+        // The app configures email_validation_mode: html5 globally (config/packages/validator.yaml);
+        // the standalone builder would otherwise fall back to the deprecated "loose" mode.
+        $validatorFactory = new ConstraintValidatorFactory([
+            EmailValidator::class => new EmailValidator(Email::VALIDATION_MODE_HTML5),
+        ]);
+
+        return Validation::createValidatorBuilder()
+            ->enableAttributeMapping()
+            ->setConstraintValidatorFactory($validatorFactory)
+            ->getValidator()
+            ->validate($booking, null, $groups);
+    }
+}

tests/Form/Model/OfferAcceptDtoTest.php

@@ -0,0 +1,54 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Tests\Form\Model;
+
+use App\Form\Model\OfferAcceptDto;
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\Validator\Validation;
+use Symfony\Component\Validator\Validator\ValidatorInterface;
+
+class OfferAcceptDtoTest extends TestCase
+{
+    public function testAcceptedTermsWithoutRemarksIsValid(): void
+    {
+        $violations = $this->validator()->validate(new OfferAcceptDto(termsAccepted: true));
+
+        self::assertCount(0, $violations);
+    }
+
+    public function testUncheckedTermsAreRejected(): void
+    {
+        $violations = $this->validator()->validate(new OfferAcceptDto(remarks: 'Bitte Zimmer im EG'));
+
+        self::assertCount(1, $violations);
+        self::assertSame('termsAccepted', $violations[0]->getPropertyPath());
+        self::assertSame('Bitte akzeptiere die AGB, um die Buchung abzuschließen.', $violations[0]->getMessage());
+    }
+
+    public function testRemarksAreCappedAt2000Characters(): void
+    {
+        $dto = new OfferAcceptDto(termsAccepted: true, remarks: str_repeat('a', 2001));
+
+        $violations = $this->validator()->validate($dto);
+
+        self::assertCount(1, $violations);
+        self::assertSame('remarks', $violations[0]->getPropertyPath());
+        self::assertSame('Die Anmerkungen dürfen maximal 2000 Zeichen lang sein.', $violations[0]->getMessage());
+    }
+
+    public function testRemarksAtTheLimitAreAccepted(): void
+    {
+        $dto = new OfferAcceptDto(termsAccepted: true, remarks: str_repeat('a', 2000));
+
+        self::assertCount(0, $this->validator()->validate($dto));
+    }
+
+    private function validator(): ValidatorInterface
+    {
+        return Validation::createValidatorBuilder()
+            ->enableAttributeMapping()
+            ->getValidator();
+    }
+}