EP/myep
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove overzealous access check rendering invoice download impossible

Browse Source
This commit is contained in:
Björn Fromme
2025-04-28 11:21:29 +02:00
parent c37309b3c1
commit b56078ae58
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Controller/Booking/DownloadController.php
-12
View File
@@ -16,7 +16,6 @@ use Symfony\Component\HttpFoundation\StreamedResponse;
use Symfony\Component\Routing\Attribute\Route; use Symfony\Component\Routing\Attribute\Route;
use Symfony\Component\Security\Http\Attribute\IsGranted; use Symfony\Component\Security\Http\Attribute\IsGranted;
use Symfony\Contracts\Cache\CacheInterface; use Symfony\Contracts\Cache\CacheInterface;
use function Symfony\Component\String\u; use function Symfony\Component\String\u;
class DownloadController extends AbstractController class DownloadController extends AbstractController
@@ -62,17 +61,6 @@ class DownloadController extends AbstractController
'booking_id' => $id, 'booking_id' => $id,
]); ]);
// Fetch booking data via API and cache result for a short ttl to check permissions
$bookingData = $this->fetchBookingData($email, $password, $id);
if (null === $bookingData || $bookingData instanceof Notification) {
$this->addFlash('error', 'Buchungsdaten nicht (mehr) verfügbar');
return $this->redirectToRoute('app_bookings');
}
$this->denyAccessUnlessGranted('VIEW', $bookingData);
try { try {
$file = $this $file = $this
->apiClient ->apiClient