EP/myep
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: revert pickup pricing to match current BusPro behavior

Browse Source 
Reverts split pricing calculation to use outbound-only pricing,
matching BusPro's current behavior where pickup is only charged when
outbound transportation is BUS.

- Use pickup->price directly instead of calculateEffectivePrice()
- PKW+BUS scenario now correctly charges €0 (matches BusPro loophole)
- priceOutbound/priceInbound remain populated for future activation
- Updated documentation with current behavior and future plan
This commit is contained in:
Björn Fromme
2026-03-16 12:02:59 +01:00
parent c1425f0562
commit b68d5c9398
6 changed files with 262 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Service/ParticipantPricingCalculator.php
+3 -2
View File
@@ -230,8 +230,9 @@ class ParticipantPricingCalculator
}
}
// Pickup pricing - only charged when outbound transportation is bus
// BusProNet API ignores pickup surcharges for self-organized (PKW) outbound
// Pickup pricing - only charged when outbound transportation is BUS
// This matches current BusPro behavior where pickup price is only applied for outbound bus
// Note: priceOutbound/priceInbound are populated for future split pricing support when BusPro is updated
$hasOutboundBus = null !== $participant->transportationOutbound
&& 'BUS' === $participant->transportationOutbound->subType;
src/Service/ServicePricingCalculator.php
+3 -2
View File
@@ -129,8 +129,9 @@ class ServicePricingCalculator
}
}
// Pickup pricing - only charged when outbound transportation is bus
// BusProNet API ignores pickup surcharges for self-organized (PKW) outbound
// Pickup pricing - only charged when outbound transportation is BUS
// This matches current BusPro behavior where pickup price is only applied for outbound bus
// Note: priceOutbound/priceInbound are populated for future split pricing support when BusPro is updated
$hasOutboundBus = null !== $participant->transportationOutbound
&& 'BUS' === $participant->transportationOutbound->subType;