refactor: split buspro ApiClient into domain clients

src/Controller/Voucher/Step3Controller.php

@@ -4,7 +4,7 @@ declare(strict_types=1);
 
 namespace App\Controller\Voucher;
 
-use App\BusProNet\ApiClient;
+use App\BusProNet\Client\VoucherClient;
 use App\BusProNet\Exception\TimeoutException;
 use App\BusProNet\Model\Notification;
 use App\Form\Model\VoucherPurchaseDto;
@@ -32,7 +32,7 @@ class Step3Controller extends AbstractVoucherPurchaseController
     public function __construct(
         VoucherPurchaseSessionManager $sessionManager,
         VoucherThumbnailResolver $thumbnailResolver,
-        private readonly ApiClient $apiClient,
+        private readonly VoucherClient $voucherClient,
         private readonly VoucherSaleRejectionMapper $rejectionMapper,
         private readonly LoggerInterface $logger,
     ) {
@@ -78,7 +78,7 @@ class Step3Controller extends AbstractVoucherPurchaseController
     private function runDryRun(Request $request, VoucherPurchaseDto $dto, FormInterface $form): Response
     {
         try {
-            $response = $this->apiClient->createVoucherSaleInquiry($dto);
+            $response = $this->voucherClient->createVoucherSaleInquiry($dto);
         } catch (\Exception $e) {
             $this->logger->error('Voucher sale inquiry failed', ['exception' => $e->getMessage()]);
             $this->addFlash('error', 'Der Gutscheinkauf konnte gerade nicht geprüft werden. Bitte versuche es später noch einmal.');
@@ -106,7 +106,7 @@ class Step3Controller extends AbstractVoucherPurchaseController
     private function purchase(Request $request, VoucherPurchaseDto $dto, FormInterface $form): Response
     {
         try {
-            $response = $this->apiClient->createVoucherSale($dto);
+            $response = $this->voucherClient->createVoucherSale($dto);
         } catch (TimeoutException $e) {
             // The purchase may have gone through on BusPro's side, so a blind retry could buy twice
             $this->logger->error('Voucher sale timeout', ['exception' => $e->getMessage()]);