feat: upgrade phpunit to 12.5

tests/Controller/Account/PersonalDataControllerTest.php

@@ -27,7 +27,10 @@ class PersonalDataControllerTest extends TestCase
 {
     public function testIndexRendersNewsletterSubscribeCtaWhenNotSubscribed(): void
     {
-        $controller = $this->createController();
+        $controller = $this->createController(
+            apiClient: $this->createMock(ApiClient::class),
+            newsletterManager: $this->createMock(NewsletterManager::class),
+        );
         $controller->apiClient
             ->expects(self::once())
             ->method('getPersonalData')
@@ -55,7 +58,10 @@ class PersonalDataControllerTest extends TestCase
 
     public function testIndexStillTracksPendingNewsletterConfirmationWhenSubscribed(): void
     {
-        $controller = $this->createController();
+        $controller = $this->createController(
+            apiClient: $this->createMock(ApiClient::class),
+            newsletterManager: $this->createMock(NewsletterManager::class),
+        );
         $controller->apiClient
             ->expects(self::once())
             ->method('getPersonalData')
@@ -82,7 +88,10 @@ class PersonalDataControllerTest extends TestCase
 
     public function testNewsletterActionReturnsHtmxRedirectAndFlash(): void
     {
-        $controller = $this->createController();
+        $controller = $this->createController(
+            apiClient: $this->createMock(ApiClient::class),
+            newsletterManager: $this->createMock(NewsletterManager::class),
+        );
         $controller->apiClient
             ->expects(self::once())
             ->method('getPersonalData')
@@ -122,7 +131,10 @@ class PersonalDataControllerTest extends TestCase
 
     public function testNewsletterActionResendsPendingConfirmation(): void
     {
-        $controller = $this->createController();
+        $controller = $this->createController(
+            apiClient: $this->createMock(ApiClient::class),
+            newsletterManager: $this->createMock(NewsletterManager::class),
+        );
         $controller->apiClient
             ->expects(self::once())
             ->method('getPersonalData')
@@ -173,7 +185,10 @@ class PersonalDataControllerTest extends TestCase
      */
     public function testIndexDoesNotSubmitTheFormWhenPersonalDataCouldNotBeLoaded(): void
     {
-        $controller = $this->createController();
+        $controller = $this->createController(
+            apiClient: $this->createMock(ApiClient::class),
+            form: $this->createMock(FormInterface::class),
+        );
         $controller->apiClient
             ->expects(self::once())
             ->method('getPersonalData')
@@ -194,20 +209,25 @@ class PersonalDataControllerTest extends TestCase
         self::assertSame('account/personal_data.html.twig', $controller->renderedView);
     }
 
-    private function createController(): TestablePersonalDataController
-    {
+    /**
+     * Collaborators default to stubs; a test passes its own mock for whatever it sets
+     * expectations on, and reaches it again through the controller's public property.
+     */
+    private function createController(
+        ?ApiClient $apiClient = null,
+        ?NewsletterManager $newsletterManager = null,
+        ?FormInterface $form = null,
+    ): TestablePersonalDataController {
         $user = new User('[email protected]');
         $user->setPassword('secret');
 
-        $apiClient = $this->createMock(ApiClient::class);
-
         $crypt = $this->createMock(Crypt::class);
         $crypt
             ->method('decrypt')
             ->with('secret')
             ->willReturn('secret');
 
-        $form = $this->createMock(FormInterface::class);
+        $form ??= $this->createStub(FormInterface::class);
         $form
             ->method('handleRequest')
             ->willReturnSelf();
@@ -216,13 +236,13 @@ class PersonalDataControllerTest extends TestCase
             ->willReturn(false);
 
         return new TestablePersonalDataController(
-            $apiClient,
+            $apiClient ?? $this->createStub(ApiClient::class),
             $crypt,
-            $this->createMock(BookingEditDataLoader::class),
-            $this->createMock(ProfileCompletenessChecker::class),
-            $this->createMock(EntityManagerInterface::class),
-            $this->createMock(NewsletterManager::class),
-            $this->createMock(LoggerInterface::class),
+            $this->createStub(BookingEditDataLoader::class),
+            $this->createStub(ProfileCompletenessChecker::class),
+            $this->createStub(EntityManagerInterface::class),
+            $newsletterManager ?? $this->createStub(NewsletterManager::class),
+            $this->createStub(LoggerInterface::class),
             $user,
             $form,
         );