EP/myep
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: upgrade phpunit to 12.5

Browse Source
This commit is contained in:
Björn Fromme
2026-08-31 09:31:00 +02:00
parent 010cfe56b2
commit bfad61f1dd
95 changed files with 1436 additions and 1224 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Service/BookingSessionManagerTest.php
+19 -13
View File
@@ -19,12 +19,16 @@ use Symfony\Component\HttpFoundation\Session\Storage\MockArraySessionStorage;
class BookingSessionManagerTest extends TestCase
{
private TravelDataProvider $travelDataService;
private BookingSessionManager $service;
private ?BookingSessionManager $service = null;
protected function setUp(): void
{
$this->travelDataService = $this->createMock(TravelDataProvider::class);
$this->service = new BookingSessionManager($this->travelDataService);
$this->travelDataService = $this->createStub(TravelDataProvider::class);
}
private function service(): BookingSessionManager
{
return $this->service ??= new BookingSessionManager($this->travelDataService);
}
public function testGetOrCreateBookingCreateDtoThrowsWhenSessionMissing(): void
@@ -33,11 +37,13 @@ class BookingSessionManagerTest extends TestCase
$this->expectException(BookingSessionNotFoundException::class);
$this->service->getOrCreateBookingCreateDto($request);
$this->service()->getOrCreateBookingCreateDto($request);
}
public function testSaveAndLoadBookingDtoHydratesTravel(): void
{
$this->travelDataService = $this->createMock(TravelDataProvider::class);
$request = $this->createRequestWithSession();
$storedTravel = new Travel();
@@ -59,8 +65,8 @@ class BookingSessionManagerTest extends TestCase
->with(12, 34)
->willReturn($hydratedTravel);
$this->service->saveBookingDto($request, $bookingDto, BookingDto::MODE_CREATE);
$loadedDto = $this->service->getBookingDto($request, BookingDto::MODE_CREATE);
$this->service()->saveBookingDto($request, $bookingDto, BookingDto::MODE_CREATE);
$loadedDto = $this->service()->getBookingDto($request, BookingDto::MODE_CREATE);
$this->assertNotNull($loadedDto);
$this->assertSame($hydratedTravel, $loadedDto?->travel);
@@ -76,11 +82,11 @@ class BookingSessionManagerTest extends TestCase
$selection->quantity = 2;
$bookingDto->roomSelections = [$selection];
$first = $this->service->getOrCreateBaselineSnapshot($request, $bookingDto);
$first = $this->service()->getOrCreateBaselineSnapshot($request, $bookingDto);
$this->assertSame([[1, 2]], $first);
$selection->quantity = 5;
$second = $this->service->getOrCreateBaselineSnapshot($request, $bookingDto);
$second = $this->service()->getOrCreateBaselineSnapshot($request, $bookingDto);
$this->assertSame($first, $second);
$this->assertSame([[1, 2]], $second);
@@ -90,19 +96,19 @@ class BookingSessionManagerTest extends TestCase
{
$request = $this->createRequestWithSession();
$this->service->storeReturnUrl($request, 'javascript:alert(1)');
$this->service()->storeReturnUrl($request, 'javascript:alert(1)');
$this->assertSame(BookingSessionManager::DEFAULT_RETURN_URL, $this->service->getReturnUrl($request));
$this->assertSame(BookingSessionManager::DEFAULT_RETURN_URL, $this->service()->getReturnUrl($request));
}
public function testClearBookingSessionPreservesReturnUrl(): void
{
$request = $this->createRequestWithSession();
$this->service->storeReturnUrl($request, 'https://example.test/after-booking');
$this->service->clearBookingSession($request);
$this->service()->storeReturnUrl($request, 'https://example.test/after-booking');
$this->service()->clearBookingSession($request);
$this->assertSame('https://example.test/after-booking', $this->service->getReturnUrl($request));
$this->assertSame('https://example.test/after-booking', $this->service()->getReturnUrl($request));
}
private function createRequestWithSession(): Request