diff --git a/src/BusProNet/Model/Notification.php b/src/BusProNet/Model/Notification.php index e54078c..ff342f4 100644 --- a/src/BusProNet/Model/Notification.php +++ b/src/BusProNet/Model/Notification.php @@ -13,13 +13,8 @@ class Notification public ?int $code; public ?string $message; - public function isSuccessful(): bool + public function isError(): bool { - // Successful responses don't carry codes and messages - if (null === $this->code && null === $this->message) { - return true; - } - - return 650 === $this->code && false === stripos($this->message, 'fehler'); + return 650 !== $this->code; } } diff --git a/src/Controller/Booking/EditController.php b/src/Controller/Booking/EditController.php index b73cee0..0d8d93a 100644 --- a/src/Controller/Booking/EditController.php +++ b/src/Controller/Booking/EditController.php @@ -94,9 +94,13 @@ class EditController extends AbstractController 'email' => $bpnUser->getEmail(), 'booking_id' => $id, ]); - if ($response instanceof Notification && false === $response->isSuccessful()) { - $this->addFlash('error', $response->message); - $this->logger->error('Error initiating booking update', [ + if ($response instanceof Notification) { + if (true === $response->isError()) { + $this->addFlash('error', $response->message); + } else { + $this->addFlash('info', $response->message); + } + $this->logger->error('Booking update not successful', [ 'email' => $bpnUser->getEmail(), 'booking_id' => $id, 'message' => $response->message, diff --git a/src/Controller/RegistrationController.php b/src/Controller/RegistrationController.php index 8cd64a5..9e2e6f0 100644 --- a/src/Controller/RegistrationController.php +++ b/src/Controller/RegistrationController.php @@ -34,10 +34,10 @@ class RegistrationController extends AbstractController if ($form->isSubmitted() && $form->isValid()) { try { $response = $this->apiClient->register($registrationData); - if ($response->isSuccessful()) { - $this->addFlash('success', 'Du erhältst in Kürze eine E-Mail mit einem Link zum (Zurück)setzen deines Passworts.'); - } else { + if (true === $response->isError()) { $this->addFlash('error', 'Möglicherweise bist du bereits registriert. Bitte setze dein Passwort zurück.'); + } else { + $this->addFlash('success', 'Du erhältst in Kürze eine E-Mail mit einem Link zum (Zurück)setzen deines Passworts.'); } $this->logger->info('Initiated registration', [ 'email' => $registrationData->email, @@ -57,4 +57,4 @@ class RegistrationController extends AbstractController 'form' => $form->createView(), ]); } -} \ No newline at end of file +}