fix: resolve stale dependent selections after booking family insurance

src/Service/BookingPricingAssembler.php

@@ -23,8 +23,6 @@ class BookingPricingAssembler
     public function __construct(
         private readonly RoomPricingCalculator $roomPricingCalculator,
         private readonly ParticipantEligibilityChecker $participantEligibilityChecker,
-        private readonly InsuranceManager $insuranceService,
-        private readonly ParticipantPricingCalculator $participantPricingCalculator,
     ) {
     }
 
@@ -327,7 +325,9 @@ class BookingPricingAssembler
             $this->addToServiceAggregation($serviceAggregation, $participant->rentalInsurance);
         }
 
-        $insuranceToAggregate = $this->resolveInsuranceForAggregation($participant, $bookingDto);
+        // The session DTO is kept truthful by ApplicantInsuranceCascade, which materialises
+        // bulk and family assignments as they are made - so this is simply what the participant holds.
+        $insuranceToAggregate = $participant->insurance;
         if (null !== $insuranceToAggregate && null !== $insuranceToAggregate->price && false === $insuranceToAggregate->isNoInsurance()) {
             $this->addInsuranceToServiceAggregation($serviceAggregation, $insuranceToAggregate);
         }
@@ -404,38 +404,4 @@ class BookingPricingAssembler
             'subType' => $serviceData['subType'] ?? null,
         ];
     }
-
-    private function resolveInsuranceForAggregation(ParticipantDto $participant, BookingDto $bookingDto): ?Insurance
-    {
-        if (null !== $participant->insurance) {
-            return $participant->insurance;
-        }
-
-        $applicant = $bookingDto->getParticipant(0);
-        if (null === $applicant || false === $applicant->bulkInsuranceBooking || null === $applicant->insurance) {
-            return null;
-        }
-
-        if (0 === $participant->index) {
-            return $participant->insurance;
-        }
-
-        $selectableInsurances = $this->insuranceService->getSelectableInsurances($bookingDto->travel);
-        $sameTypeInsurances = $this->insuranceService->filterByType(
-            $selectableInsurances,
-            $applicant->insurance
-        );
-        $travelPrice = $this->participantPricingCalculator->calculateIndividualParticipantPriceExcludingInsurance(
-            $bookingDto,
-            $participant->index
-        );
-        $eligibleInsurances = $this->insuranceService->getEligibleInsurances(
-            $sameTypeInsurances,
-            $participant,
-            $bookingDto,
-            $travelPrice
-        );
-
-        return !empty($eligibleInsurances) ? array_values($eligibleInsurances)[0] : null;
-    }
 }