EP/myep
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: corrupted logic of model transformer

Browse Source
This commit is contained in:
Björn Fromme
2026-04-16 16:40:38 +02:00
parent 0fcecc9c58
commit ca5a604a3e
2 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Form/DataTransformer/RoomSelectionToIdTransformer.php
+2 -6
View File
@@ -59,12 +59,8 @@ class RoomSelectionToIdTransformer implements DataTransformerInterface
return null;
}
if (is_int($value)) {
return $value;
}
if (is_string($value) && ctype_digit($value)) {
return (int) $value;
if ($value instanceof RoomSelectionDto) {
return $value->id;
}
throw new TransformationFailedException(sprintf(
tests/Form/DataTransformer/RoomSelectionToIdTransformerTest.php
+8 -5
View File
@@ -11,12 +11,15 @@ use Symfony\Component\Form\Exception\TransformationFailedException;
class RoomSelectionToIdTransformerTest extends TestCase
{
public function testReverseTransformAcceptsIntegerAndNumericStringIds(): void
public function testReverseTransformAcceptsRoomSelectionDto(): void
{
$transformer = new RoomSelectionToIdTransformer([]);
$roomSelection = new RoomSelectionDto();
$roomSelection->id = 7;
$roomSelection->label = 'Doppelzimmer';
self::assertSame(12, $transformer->reverseTransform(12));
self::assertSame(12, $transformer->reverseTransform('12'));
$transformer = new RoomSelectionToIdTransformer([$roomSelection]);
self::assertSame(7, $transformer->reverseTransform($roomSelection));
}
public function testReverseTransformReturnsNullForEmptyValues(): void
@@ -33,7 +36,7 @@ class RoomSelectionToIdTransformerTest extends TestCase
$this->expectException(TransformationFailedException::class);
$transformer->reverseTransform('1.5');
$transformer->reverseTransform('12');
}
public function testTransformReturnsMatchingRoomSelectionDto(): void