feat: force booking status 'O' for selection id 1473

addresses #869d79q0r
This commit is contained in:
Björn Fromme
2026-06-11 15:53:56 +02:00
parent bcf75ce3c3
commit d207bc74cb
9 changed files with 318 additions and 5 deletions
@@ -6,11 +6,14 @@ namespace App\Tests\Service;
use App\Form\Model\BookingDto;
use App\Form\Model\ParticipantDto;
use App\BusProNet\Model\CrmSelection;
use App\BusProNet\Model\CrmSelectionGroup;
use App\BusProNet\Constants;
use App\BusProNet\Model\Room;
use App\BusProNet\Model\Service;
use App\BusProNet\Model\Travel;
use App\BusProNet\Service\BookingStatusRuleRegistry;
use App\BusProNet\Service\StatusRule\Selection1473StatusRule;
use App\BusProNet\XmlLoader\AgencyLoader;
use App\Exception\NoRoomsAvailableException;
use App\Service\BookingConfigurator;
@@ -174,6 +177,57 @@ class BookingConfiguratorStatusTest extends TestCase
$this->assertSame('A', $bookingDto->bookingStatus);
}
public function testStartFreshBookingWithSelection1473UsesOptionStatus(): void
{
$bookingService = new BookingConfigurator(
$this->createMock(BookingSessionManager::class),
$this->travelDataService,
$this->createMock(ParticipantEligibilityChecker::class),
new BookingStatusRuleRegistry([
new Selection1473StatusRule(),
]),
$this->createMock(AgencyLoader::class),
'F'
);
$travel = $this->createTravelWithRooms(
[
['status' => Constants::STATUS_AVAILABLE, 'available' => 5],
],
[$this->createSelectionGroupWithSelectionId(1473)]
);
$this->travelDataService
->method('getTravelData')
->willReturn($travel);
$request = $this->createRequestWithSession();
$bookingDto = $bookingService->startFreshBooking($request, 123, 456);
$this->assertSame('O', $bookingDto->bookingStatus);
}
public function testStartFreshBookingWithInquiryRoomsAndSelection1473KeepsInquiryStatus(): void
{
$travel = $this->createTravelWithRooms(
[
['status' => Constants::STATUS_ON_REQUEST, 'available' => 5],
],
[$this->createSelectionGroupWithSelectionId(1473)]
);
$this->travelDataService
->method('getTravelData')
->willReturn($travel);
$request = $this->createRequestWithSession();
$bookingDto = $this->bookingService->startFreshBooking($request, 123, 456);
$this->assertSame('A', $bookingDto->bookingStatus);
}
public function testApplyCreateBookingStatusRulesSetsOptionFromRegistry(): void
{
$bookingStatusRuleRegistry = $this->createMock(BookingStatusRuleRegistry::class);
@@ -236,7 +290,7 @@ class BookingConfiguratorStatusTest extends TestCase
/**
* @param array<array{status: string, available: int}> $roomsConfig
*/
private function createTravelWithRooms(array $roomsConfig): Travel
private function createTravelWithRooms(array $roomsConfig, array $selectionGroups = []): Travel
{
$travel = new Travel();
$travel->id = 123;
@@ -244,6 +298,7 @@ class BookingConfiguratorStatusTest extends TestCase
$travel->dateFrom = new \DateTimeImmutable('2030-01-01');
$travel->dateTo = new \DateTimeImmutable('2030-01-06');
$travel->allowedBookingStatus = []; // Empty means no API restrictions
$travel->selectionGroups = $selectionGroups;
$rooms = [];
foreach ($roomsConfig as $index => $config) {
@@ -265,6 +320,24 @@ class BookingConfiguratorStatusTest extends TestCase
return $travel;
}
/**
* @param list<int> $selectionIds
*/
private function createSelectionGroupWithSelectionId(int $groupId, array $selectionIds = [1473]): CrmSelectionGroup
{
$group = new CrmSelectionGroup();
$group->id = $groupId;
$group->selections = [];
foreach ($selectionIds as $selectionId) {
$selection = new CrmSelection();
$selection->id = $selectionId;
$group->selections[] = $selection;
}
return $group;
}
private function createRequestWithSession(): Request
{
$session = new Session(new MockArraySessionStorage());